Skip to content

[Backport] Fix browser cookie tests to only run with HTTPS #39680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

BrennanConroy
Copy link
Member

Backport of #39665

@BrennanConroy BrennanConroy added area-signalr Includes: SignalR clients and servers tell-mode Indicates a PR which is being merged during tell-mode labels Jan 21, 2022
@BrennanConroy BrennanConroy added this to the 5.0.14 milestone Jan 21, 2022
@ghost ghost modified the milestones: 5.0.14, 5.0.x Jan 21, 2022
@ghost
Copy link

ghost commented Jan 21, 2022

Hi @BrennanConroy. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@wtgodbe
Copy link
Member

wtgodbe commented Jan 25, 2022

Combined this with #39690 to unblock CI

@dougbu
Copy link
Contributor

dougbu commented Feb 2, 2022

Closing in favour of #39923. I cherry-picked all commits from here to there.

@dougbu dougbu closed this Feb 2, 2022
@dougbu dougbu deleted the brecon/50cookie branch February 2, 2022 00:13
@dougbu dougbu removed this from the 5.0.x milestone Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants