Skip to content

[release/5.0] Improve File access issues #39732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 2, 2022
Merged

[release/5.0] Improve File access issues #39732

merged 8 commits into from
Feb 2, 2022

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 24, 2022

Attempt to improve #32219 in 5.0 by backporting parts of #34137 and #39336. If this doesn't help enough we can backport #37338 as well, but that's more involved.

@wtgodbe wtgodbe requested a review from a team January 24, 2022 18:41
@wtgodbe wtgodbe requested review from SteveSandersonMS, Tratcher and a team as code owners January 24, 2022 18:41
@ghost ghost added this to the 5.0.x milestone Jan 24, 2022
@ghost
Copy link

ghost commented Jan 24, 2022

Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 24, 2022
@dougbu
Copy link
Contributor

dougbu commented Jan 24, 2022

Should this be in area-infrastructure

@wtgodbe wtgodbe added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 24, 2022
@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 24, 2022

Should this be in area-infrastructure❔

Yes

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 25, 2022

@BrennanConroy do you know what project I excluded here to cause all the typescript tests to fail?

@BrennanConroy
Copy link
Member

#39680 and #39690 are needed for 5.0

@wtgodbe wtgodbe merged commit 73320ae into dotnet:release/5.0 Feb 2, 2022
@wtgodbe wtgodbe deleted the wtgodbe/CantAccessFile5 branch February 2, 2022 17:34
@dougbu dougbu modified the milestones: 5.0.x, 5.0.15 Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants