Skip to content

[release/6.0] (deps): Bump src/submodules/googletest from 6b74da4 to 4517697 #39905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2022

Bumps src/submodules/googletest from 6b74da4 to 4517697.

Commits
  • 4517697 Merge pull request #3744 from danger89:patch-2
  • 28e1da2 Finish some missed pieces of the TestCase to TestSuite Migration
  • 0b7798b Change ReturnArg to use perfect forwarding of arguments (#3733)
  • f2d71f0 Let me give a change to try it again - updating to latest version
  • f45d586 Make recreate_environments_when_repeating=false the default.
  • 7eae8de Merge pull request #3723 from ramkumar-kr:patch-1
  • f64cf6b Merge pull request #3732 from joshiayush:i2174
  • 3d81736 Merge pull request #3615 from IYP-Programer-Yeah:fix-per-test-filter-processing
  • 2ddfdf8 Factor out AssertionResult into dedicated gtest-assertion-result header + imp...
  • 100f6fb Consistently apply IWYU pragmas across googletest and googlemock headers
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [src/submodules/googletest](https://github.com/google/googletest) from `6b74da4` to `4517697`.
- [Release notes](https://github.com/google/googletest/releases)
- [Commits](google/googletest@6b74da4...4517697)

---
updated-dependencies:
- dependency-name: src/submodules/googletest
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested review from dougbu, wtgodbe and a team as code owners February 1, 2022 12:02
@dependabot dependabot bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 1, 2022
@ghost ghost added this to the 6.0.x milestone Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

Hi @dependabot[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@TanayParikh TanayParikh enabled auto-merge (squash) February 1, 2022 17:43
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Feb 1, 2022
@TanayParikh
Copy link
Contributor

CI keeps failing across release branch updates.

YARN(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) No Connection with that ID: Status code '404' in wwwroot/dist/signalr-functional-tests.js (line 2554)

Any thoughts on why this may be the case?

@dougbu
Copy link
Contributor

dougbu commented Feb 1, 2022

CI keeps failing across release branch updates.

YARN(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) No Connection with that ID: Status code '404' in wwwroot/dist/signalr-functional-tests.js (line 2554)

Any thoughts on why this may be the case?

This will have to wait for #39679. Elsewhere, #39680 is needed for release/5.0 and #39681 for release/3.1. But we shouldn't merge these before the automated branding updates are in. (We'll need to include @BrennanConroy's commits in those updates.)

@wtgodbe and @vseanreesermsft are those PRs expected soon❔

@TanayParikh TanayParikh added the blocked The work on this issue is blocked due to some dependency label Feb 1, 2022
@TanayParikh
Copy link
Contributor

This will have to wait for #39679. Elsewhere, #39680 is needed for release/5.0 and #39681 for release/3.1. But we shouldn't merge these before the automated branding updates are in. (We'll need to include @BrennanConroy's commits in those updates.)

The 3.1 submodule update already got merged, will that be an issue?

@TanayParikh TanayParikh disabled auto-merge February 1, 2022 19:19
@dougbu
Copy link
Contributor

dougbu commented Feb 1, 2022

The 3.1 submodule update already got merged, will that be an issue?

Probably not. Worst case is the change will result in an official build that flows old versions into dotnet/sdk. Even that doesn't seem like a big deal. Agreed @wtgodbe

@wtgodbe
Copy link
Member

wtgodbe commented Feb 1, 2022

The 3.1 submodule update already got merged, will that be an issue?

In this case it's fine, since we didn't build 3.1 for February, we don't need to wait for its branding to be updated for March

@wtgodbe
Copy link
Member

wtgodbe commented Feb 2, 2022

/azp run

@wtgodbe wtgodbe enabled auto-merge (squash) February 2, 2022 17:36
@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu dougbu removed the blocked The work on this issue is blocked due to some dependency label Feb 2, 2022
@wtgodbe
Copy link
Member

wtgodbe commented Feb 2, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe wtgodbe merged commit 3de4a41 into release/6.0 Feb 4, 2022
@wtgodbe wtgodbe deleted the dependabot/submodules/release/6.0/src/submodules/googletest-4517697 branch February 4, 2022 19:10
@wtgodbe wtgodbe modified the milestones: 6.0.x, 6.0.3 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants