feat: add StringSyntaxAttribute for guid and timespan args #48402

abc516 · 2023-05-24T03:32:42Z

#44535 (GuidFormat and TimeSpanFormat)

You've read the Contributor Guide and Code of Conduct.
There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Adds the StringSyntaxAttribute for guid and timespan string function parameters, to specify syntax adherence.

ghost · 2023-05-24T03:32:49Z

Thanks for your PR, @abc516. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

abc516 · 2023-05-24T03:40:56Z

@dotnet-policy-service agree

@abc516 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@dotnet-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement

BrennanConroy · 2023-05-24T15:33:47Z

This is test code, applying the string syntax attribute isn't very interesting in these cases.

...to avoid false positive from debugger display types and simplify test for `X509Certificate`.

* Use `Type.IsByRefLike`. * Inline `IsRefStructProperty`; it is used only once and is small.

* Update JSInProcessObjectReference.cs Fix for bug dotnet#48280 * Add JSObjectReferences dispose tests --------- Co-authored-by: Mackinnon Buck <[email protected]>

…48398) * Transitive package to provide coherency in dotnet/extensions * Update Version.Details.xml --------- Co-authored-by: William Godbe <[email protected]>

…embly (dotnet#48409)

* Update dependencies from https://github.com/dotnet/runtime build 20230524.1 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting From Version 8.0.0-preview.5.23273.1 -> To Version 8.0.0-preview.5.23274.1 * Use Microsoft.Extensions.Diaganostics * Add to shared framework * Add Diagnostics.Abstractions to shared fx. * Remove InternalsVisibleTo workaround. Add some dispose logic to TestMeterFactory. * Fix test build. Add new assemblies to shared fx * Fix new deps * Update dependencies from https://github.com/dotnet/runtime build 20230524.13 Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting From Version 8.0.0-preview.5.23273.1 -> To Version 8.0.0-preview.5.23274.13 * Update new dependencies to new runtime build --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: James Newton-King <[email protected]> Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: wtgodbe <[email protected]>

…ence-packages build 20230524.2 (dotnet#48408) Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 8.0.0-alpha.1.23273.1 -> To Version 8.0.0-alpha.1.23274.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

dotnet#48238) * Change API template to only use Invariant Globalization in Native AOT mode.

…0526.1 (dotnet#48444) [main] Update dependencies from dotnet/runtime

Bumps [src/submodules/spa-templates](https://github.com/dotnet/spa-templates) from `3881d5a` to `45228c8`. - [Commits](dotnet/spa-templates@3881d5a...45228c8) --- updated-dependencies: - dependency-name: src/submodules/spa-templates dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [src/submodules/googletest](https://github.com/google/googletest) from `cb455a7` to `4580469`. - [Release notes](https://github.com/google/googletest/releases) - [Commits](google/googletest@cb455a7...4580469) --- updated-dependencies: - dependency-name: src/submodules/googletest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Updated `LoginDisplay.IndividualB2CAuth.razor` to use `OptionsMonitor.Get`

…s` (dotnet#48385) * Fix project resolution logic in user-jwts to close dotnet#46218 * Update write stream construction to close dotnet#44869 * Address review feedback

…48369)

…0526.2 (dotnet#48467) [main] Update dependencies from dotnet/runtime

…nals build 20230524.1 (dotnet#48503) [main] Update dependencies from dotnet/source-build-externals

Bumps [src/submodules/spa-templates](https://github.com/dotnet/spa-templates) from `45228c8` to `d60cf22`. - [Commits](dotnet/spa-templates@45228c8...d60cf22) --- updated-dependencies: - dependency-name: src/submodules/spa-templates dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [src/submodules/googletest](https://github.com/google/googletest) from `4580469` to `06f44bc`. - [Release notes](https://github.com/google/googletest/releases) - [Commits](google/googletest@4580469...06f44bc) --- updated-dependencies: - dependency-name: src/submodules/googletest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…et#48572)

…tnet#48432) * Adds support for binding primitive types via [SupplyParameterFromForm] * Introduces the internal infrastructure to deal with the binding process.

* Adds support for binding collection types.

* Adds support for binding dictionaries of primitive types.

* Update SDK to 8.0.100-preview.6.23305.3 * Fix build for new 8.0 SDK - Add static keyword for method that doesn't need to be an instance method. - Change workaround for dotnet/linker#3175 to use net7.0 instead of net8.0. The ILLink.Analysis package no longer ships in net8.0. So use net7.0, like the rest of the "unsupported" TFMs use.

* Adds support for binding complex types

fixes dotnet#48528 Co-authored-by: Brian Brunner <[email protected]>

abc516 · 2023-06-07T19:14:57Z

@BrennanConroy @mkArtakMSFT I had some issues resolving upstream changes in the codebase. I will re-open a PR for this issue once they are fixed.

ghost · 2023-06-07T19:15:03Z

Hi @abc516. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

feat: add StringSyntaxAttribute for guid args

4458e40

abc516 requested review from Tratcher and BrennanConroy as code owners May 24, 2023 03:32

ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels May 24, 2023

javiercn and others added 2 commits May 24, 2023 14:22

[Blazor] Update template localization file (dotnet#48405)

4e17e96

Ensure ComponentState is always disposed (dotnet#48406)

7e3dcf7

amcasey and others added 19 commits May 24, 2023 08:54

Disable debugger support in trimming tests (dotnet#48399)

add60ed

...to avoid false positive from debugger display types and simplify test for `X509Certificate`.

Use Type.IsByRefLike. (dotnet#48351)

91d702c

* Use `Type.IsByRefLike`. * Inline `IsRefStructProperty`; it is used only once and is small.

Update JSInProcessObjectReference.cs (dotnet#48287)

90599c6

* Update JSInProcessObjectReference.cs Fix for bug dotnet#48280 * Add JSObjectReferences dispose tests --------- Co-authored-by: Mackinnon Buck <[email protected]>

Transitive package to provide coherency in dotnet/extensions (dotnet#…

a9eb3e8

…48398) * Transitive package to provide coherency in dotnet/extensions * Update Version.Details.xml --------- Co-authored-by: William Godbe <[email protected]>

Add test retries for InjectedStartup_DefaultApplicationNameIsEntryAss…

b441d4e

…embly (dotnet#48409)

[SignalR] Seamless Reconnect (dotnet#48338)

f56c242

Change API template to only use Invariant Globalization in Native AOT… (

f53a14c

dotnet#48238) * Change API template to only use Invariant Globalization in Native AOT mode.

Update dependencies from https://github.com/dotnet/runtime build 2023…

775b001

…0526.1 (dotnet#48444) [main] Update dependencies from dotnet/runtime

Remove IdentityServer from spa-templates (dotnet#48430)

7c7c9f0

[Templates] Update LoginDisplay.IndividualB2CAuth.razor (dotnet#47654)

08a443e

Updated `LoginDisplay.IndividualB2CAuth.razor` to use `OptionsMonitor.Get`

Update project resolution and app settings writes in `dotnet user-jwt…

0f8dae4

…s` (dotnet#48385) * Fix project resolution logic in user-jwts to close dotnet#46218 * Update write stream construction to close dotnet#44869 * Address review feedback

Migrate RDF-specific tests to shared infrastructure (part 2) (dotnet#…

d19463b

…48369)

The unit test now uses the correct exception handler (dotnet#48459)

2a70935

Update dependencies from https://github.com/dotnet/runtime build 2023…

d0e9442

…0526.2 (dotnet#48467) [main] Update dependencies from dotnet/runtime

Update dependencies from https://github.com/dotnet/source-build-exter…

f6048bb

…nals build 20230524.1 (dotnet#48503) [main] Update dependencies from dotnet/source-build-externals

dependabot bot and others added 13 commits June 6, 2023 18:07

Expose SNI hostname in ITlsHandshakeFeature for Kestrel/HttpSys (dotn…

e5c9648

…et#48572)

Minor debugging visualizer cleanup (dotnet#48632)

b97a36e

[Blazor] Support for primitive types in [SupplyParameterFromForm] (do…

3863fdb

…tnet#48432) * Adds support for binding primitive types via [SupplyParameterFromForm] * Introduces the internal infrastructure to deal with the binding process.

[Blazor] SupplyParameterFromForm primitive collections (dotnet#48559)

07e42c1

* Adds support for binding collection types.

[Blazor] SupplyParameterFromForm dictionary support (dotnet#48565)

110522a

* Adds support for binding dictionaries of primitive types.

[Blazor] SupplyParameterFromForm complex type support. (dotnet#48567)

8dea0b8

* Adds support for binding complex types

Handle methods that never return in Api Analyzers (dotnet#48623)

97acf9d

fixes dotnet#48528 Co-authored-by: Brian Brunner <[email protected]>

Add missing space to error message (dotnet#48653)

0457685

ref: add StringSyntaxAttribute to Kestrel server connection guid ids

ba71be1

ref: add StringSyntaxAttribute to SignalR Hub connection (guid) ids

aba2c8b

abc516 requested review from halter73, JamesNK and mgravell as code owners June 7, 2023 18:49

Anton Cataldi added 5 commits June 7, 2023 11:57

feat: add StringSyntaxAttribute for guid args

f8807e9

feat: add StringSyntaxAttribute for timespan format args

b72e9b2

ref: add StringSyntaxAttribute to Kestrel server connection guid ids

f45c90f

ref: add StringSyntaxAttribute to SignalR Hub connection (guid) ids

cec647b

Merge branch 'main' of https://github.com/abc516/aspnetcore

3b6181d

abc516 requested review from a team, wtgodbe, javiercn and captainsafia as code owners June 7, 2023 19:10

abc516 closed this Jun 7, 2023

build-analysis bot mentioned this pull request Jun 7, 2023

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add StringSyntaxAttribute for guid and timespan args #48402

feat: add StringSyntaxAttribute for guid and timespan args #48402

abc516 commented May 24, 2023 •

edited

Loading

ghost commented May 24, 2023

abc516 commented May 24, 2023

BrennanConroy commented May 24, 2023

abc516 commented Jun 7, 2023

ghost commented Jun 7, 2023

feat: add StringSyntaxAttribute for guid and timespan args #48402

feat: add StringSyntaxAttribute for guid and timespan args #48402

Conversation

abc516 commented May 24, 2023 • edited Loading

Description

ghost commented May 24, 2023

abc516 commented May 24, 2023

BrennanConroy commented May 24, 2023

abc516 commented Jun 7, 2023

ghost commented Jun 7, 2023

abc516 commented May 24, 2023 •

edited

Loading