Skip to content

Merge IISIntegration project refactoring to master from 2.2 #4962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dotnet-maestro-bot
Copy link
Contributor

I detected changes in the release/2.2 branch which have not been merged yet to master. I'm a robot and am configured to help you automatically keep master up to date, so I've opened this PR.

This PR merges commits made on release/2.2 by the following committers:

Instructions for merging

This repo does not appear to allow merge commits from the GitHub UI, so you will need to update this PR with a merge commit before closing this PR.

git fetch
git checkout release/2.2
git pull --ff-only
git checkout master
git pull --ff-only
git merge --no-ff release/2.2
# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.2-to-master
or if you are using SSH
git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.2-to-master

After PR checks are complete push the branch

git push

Please contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

@dotnet-maestro-bot
Copy link
Contributor Author

This pull request has been updated.

This PR merges commits made on release/2.2 by the following committers:

@natemcmaster natemcmaster self-assigned this Dec 14, 2018
natemcmaster and others added 2 commits December 14, 2018 08:36
Replaces package references the following packages with local code:

Microsoft.AspNetCore.Certificates.Generation.Sources
Microsoft.Extensions.CopyOnWriteDictionary.Sources 
Microsoft.Extensions.ClosedGenericMatcher.Sources
Microsoft.Extensions.ObjectMethodExecutor.Sources
Microsoft.Extensions.PropertyActivator.Sources
Microsoft.Extensions.PropertyHelper.Sources
Microsoft.Extensions.RazorViews.Sources
Microsoft.Extensions.SecurityHelper.Sources
Microsoft.Extensions.StackTrace.Sources
Microsoft.Extensions.WebEncoders.Sources
@dotnet-maestro-bot
Copy link
Contributor Author

This pull request has been updated.

This PR merges commits made on release/2.2 by the following committers:

@natemcmaster
Copy link
Contributor

I'll take care of merge conflicts. Investigating a code signing failure in 2.2 first, though...

@dotnet-maestro-bot
Copy link
Contributor Author

This pull request has been updated.

This PR merges commits made on release/2.2 by the following committers:

This file is not signable. The sign tool treats .mof as a potential signing candidate by default, even though most .mof files are not signable.
@dotnet-maestro-bot
Copy link
Contributor Author

This pull request has been updated.

This PR merges commits made on release/2.2 by the following committers:

@natemcmaster
Copy link
Contributor

Looks like installer builds fail due to layout changes in the ANCM nuget packages. Investigating...

@natemcmaster natemcmaster changed the title [automated] Merge branch 'release/2.2' => 'master' Merge IISIntegration project refactoring to master from 2.2 Dec 14, 2018
@natemcmaster natemcmaster force-pushed the merge/release/2.2-to-master branch from bf0908c to 02780ba Compare December 15, 2018 00:03
@natemcmaster
Copy link
Contributor

Build passes CI checks. Squashes commits and rebased on latest release/2.2 and master branches. I'll merge this once CI checks pass again.

@dotnet-maestro-bot
Copy link
Contributor Author

❌ Uh oh, this pull request could not be updated automatically. New commits were pushed to release/2.2, but I could not automatically push those to merge/release/2.2-to-master to update this PR.
You may need to fix this problem by merging branches with this PR. Contact .NET Core Engineering if you are not sure what to do about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants