Skip to content

Update SDK to 8.0.100-rc.1.23381.2 #49761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 31, 2023
Merged

Update SDK to 8.0.100-rc.1.23381.2 #49761

merged 9 commits into from
Jul 31, 2023

Conversation

eerhardt
Copy link
Member

Testing for dotnet/runtime#89734. Trying to see if we can repro the issue.

@eerhardt eerhardt requested review from a team and wtgodbe as code owners July 31, 2023 18:10
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 31, 2023
@eerhardt
Copy link
Member Author

@lewing @radical @javiercn - Looks like everything is failing with

/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]
/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]

Can someone fix it?

@javiercn
Copy link
Member

@eerhardt did this fail on retry?

@eerhardt
Copy link
Member Author

@eerhardt did this fail on retry?

This is failing every leg. Check the build logs.

@lewing
Copy link
Member

lewing commented Jul 31, 2023

@radical can you take a look?

@radical
Copy link
Member

radical commented Jul 31, 2023

I'm looking at the workload issue. But there are other errors too:

/Users/runner/work/1/s/src/Caching/SqlServer/src/SqlServerCache.cs(62,19): error CA2208: Method .ctor passes 'DefaultSlidingExpiration' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Caching/SqlServer/src/Microsoft.Extensions.Caching.SqlServer.csproj::TargetFramework=net8.0]
/Users/runner/work/1/s/src/Caching/SqlServer/src/SqlServerCache.cs(62,19): error CA2208: Method .ctor passes 'DefaultSlidingExpiration' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Caching/SqlServer/src/Microsoft.Extensions.Caching.SqlServer.csproj::TargetFramework=net462]
/Users/runner/work/1/s/src/Caching/SqlServer/src/SqlServerCache.cs(62,19): error CA2208: Method .ctor passes 'DefaultSlidingExpiration' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Caching/SqlServer/src/Microsoft.Extensions.Caching.SqlServer.csproj]
/Users/runner/work/1/s/src/Caching/StackExchangeRedis/src/RedisCache.cs(576,19): error CA2208: Method GetAbsoluteExpiration passes 'AbsoluteExpiration' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Caching/StackExchangeRedis/src/Microsoft.Extensions.Caching.StackExchangeRedis.csproj::TargetFramework=netstandard2.0]
/Users/runner/work/1/s/src/Caching/StackExchangeRedis/src/RedisCache.cs(576,19): error CA2208: Method GetAbsoluteExpiration passes 'AbsoluteExpiration' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Caching/StackExchangeRedis/src/Microsoft.Extensions.Caching.StackExchangeRedis.csproj]
/Users/runner/work/1/s/src/Components/Components/src/Routing/TemplateSegment.cs(96,17): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj]
/Users/runner/work/1/s/src/Components/Components/src/Routing/TemplateSegment.cs(26,41): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-dev-certs/src/dotnet-dev-certs.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-sql-cache/src/dotnet-sql-cache.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-user-jwts/src/dotnet-user-jwts.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-user-secrets/src/dotnet-user-secrets.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/GetDocumentInsider/src/GetDocument.Insider.csproj::TargetFramework=netcoreapp2.1]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/Microsoft.dotnet-openapi/src/Microsoft.dotnet-openapi.csproj]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(42,19): error CA2208: Method .ctor passes 'BatchSize' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(46,19): error CA2208: Method .ctor passes 'FlushPeriod' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(42,19): error CA2208: Method .ctor passes 'BatchSize' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(46,19): error CA2208: Method .ctor passes 'FlushPeriod' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(42,19): error CA2208: Method .ctor passes 'BatchSize' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj::TargetFramework=netstandard2.0]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(46,19): error CA2208: Method .ctor passes 'FlushPeriod' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj::TargetFramework=netstandard2.0]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/GetDocumentInsider/src/GetDocument.Insider.csproj::TargetFramework=net8.0]
/Users/runner/work/1/s/src/Http/Routing/src/Patterns/RoutePatternParser.cs(444,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Http/Routing/src/Microsoft.AspNetCore.Routing.csproj]
/Users/runner/work/1/s/src/Http/Http/src/Internal/ResponseCookies.cs(125,21): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj]
/Users/runner/work/1/s/src/Http/Http/src/Internal/ResponseCookies.cs(126,21): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj]
/Users/runner/work/1/s/src/Http/Http/src/Internal/ResponseCookies.cs(132,21): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj]
/Users/runner/work/1/s/src/Http/Http/src/Internal/ResponseCookies.cs(138,21): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj]

/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]
/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]

@eerhardt
Copy link
Member Author

But there are other errors too:

yeah, I'm fixing those

BrennanConroy and others added 6 commits July 31, 2023 13:12
@BrennanConroy
Update src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs
e36a692
@radical
WasmLinkerTest: Workaround incorrect settings in the project file
48e2278 
Issue when updating to build with rc1:
```
/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]
/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]
```

Explanation:

1. This project has `RuntimeIdentifier=browser-wasm`, which triggers the
   workload manifests for wasm
2. But the project is *not* using blazor sdk, or the wasm-sdk.
3. The condition at https://github.com/dotnet/emsdk/blob/5466de081d350d3214c1ae68b7fca6295109d5cf/eng/nuget/Microsoft.NET.Workload.Emscripten.Current.Manifest/WorkloadManifest.targets#L12

```xml
<UsingBrowserRuntimeWorkload Condition="'$(RunAOTCompilation)' == 'true' or '$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true' or '$(UsingMicrosoftNETSdkWebAssembly)' != 'true'" >true</UsingBrowserRuntimeWorkload>
```

   .. means that if a `rid=browser-wasm` project is not using blazor sdk,
   or the wasm sdk, then it depends on the targets in the workload. And
   hence requires the workload.

Solution:
As a workaround set `UsingMicrosoftNETSdkWebAssembly=true` also
(`UsingMicrosoftNETSdkBlazorWebAssembly` is already set to true).
@eerhardt
Revert "Update src/Tools/Shared/CommandLine/CommandLineApplicationExt…
39299e0 
…ensions.cs"

This reverts commit e36a692.
@eerhardt
Fix build on non-.NET Core.
17ac0eb
@eerhardt
More fixes.
d6872c4
@eerhardt
Fix ViewPath
0e5f826
@eerhardt eerhardt requested a review from a team as a code owner July 31, 2023 21:54
@eerhardt eerhardt merged commit 94f1088 into dotnet:main Jul 31, 2023
@eerhardt eerhardt deleted the UpdateSDK branch July 31, 2023 23:33
@ghost ghost added this to the 8.0-rc1 milestone Jul 31, 2023
This was referenced Jul 31, 2023
Closed
Closed
This was referenced Aug 2, 2023
Closed
Merged
@halter73 halter73 mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy left review comments

@sebastienros sebastienros sebastienros approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

@javiercn javiercn Awaiting requested review from javiercn

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
8.0-rc1
Development

Successfully merging this pull request may close these issues.
6 participants
@eerhardt @javiercn @lewing @radical @sebastienros @BrennanConroy