Skip to content

Revert "Reverting SDK (#49709)" #49763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

eerhardt
Copy link
Member

This reverts commit bf52af4.

Reproing dotnet/runtime#89734.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 31, 2023
@ghost
Copy link

ghost commented Jul 31, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@eerhardt
Copy link
Member Author

@mangod9 - the aspnetcore-ci (Build Build: Linux ARM) failed for dotnet/runtime#89734.

@eerhardt
Copy link
Member Author

eerhardt commented Jul 31, 2023

You should be able to repro with:

  1. Get on a Linux machine with this repro cloned.
  2. gh pr checkout 49763
  3. eng//build.sh --ci --nobl --configuration Release --arch arm --pack --all --no-build-nodejs --no-build-java -p:OnlyPackPlatformSpecificPackages=true -p:AssetManifestFileName=aspnetcore-Linux_arm.xml /p:SkipTestBuild=true /p:PostBuildSign=true

@eerhardt
Copy link
Member Author

eerhardt commented Aug 1, 2023

Closing this PR as #49761 moved to a newer SDK. We will monitor the CI and see if this issue comes up again.

@eerhardt eerhardt closed this Aug 1, 2023
@ghost
Copy link

ghost commented Aug 1, 2023

Hi @eerhardt. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant