Skip to content

Go back to checked-in minified .js files #56982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 25, 2024
Merged

Go back to checked-in minified .js files #56982

merged 8 commits into from
Jul 25, 2024

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jul 24, 2024

Part of #56933. Hoping to backport to preview7. Still need to create a github action for updating the .js files as a convenience for devs

@wtgodbe wtgodbe requested a review from javiercn July 24, 2024 21:40
@wtgodbe wtgodbe requested review from a team, BrennanConroy and halter73 as code owners July 24, 2024 21:40
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 24, 2024
@wtgodbe
Copy link
Member Author

wtgodbe commented Jul 24, 2024 •
edited
Loading

@javiercn hitting errors w/ https://github.com/dotnet/aspnetcore/blob/main/eng/scripts/npm/update-dependency-versions.mjs, would you mind taking a look?

Edit: Disregard, I figured it out

@wtgodbe wtgodbe mentioned this pull request Jul 24, 2024
Closed
@JamesNK
Copy link
Member

JamesNK commented Jul 25, 2024

Is this a fix for https://dev.azure.com/dnceng/internal/_build/results?buildId=2500435&view=logs&j=316d5c15-0c50-544e-8051-e6b14a1ab674&t=4e01507e-10cc-507d-f6d0-adc59e92bcb8? (from build ops active tasks)

@wtgodbe
Copy link
Member Author

wtgodbe commented Jul 25, 2024

Is this a fix for https://dev.azure.com/dnceng/internal/_build/results?buildId=2500435&view=logs&j=316d5c15-0c50-544e-8051-e6b14a1ab674&t=4e01507e-10cc-507d-f6d0-adc59e92bcb8? (from build ops active tasks)

That was fixed by #56954 - this PR goes further & basically replaces the original one that introduced that build break

javiercn
javiercn reviewed Jul 25, 2024
View reviewed changes
javiercn
javiercn reviewed Jul 25, 2024
View reviewed changes
javiercn
javiercn reviewed Jul 25, 2024
View reviewed changes
@wtgodbe
Copy link
Member Author

wtgodbe commented Jul 25, 2024

/backport to release/9.0-preview7

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0-preview7: https://github.com/dotnet/aspnetcore/actions/runs/10098066453

@github-actions github-actions bot mentioned this pull request Jul 25, 2024
Merged
11 tasks
@wtgodbe wtgodbe merged commit 98fca5e into main Jul 25, 2024
@wtgodbe wtgodbe deleted the wtgodbe/GoBackToCheckedIn branch July 25, 2024 19:27
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc1 milestone Jul 25, 2024
This was referenced Jul 26, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn javiercn approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@halter73 halter73 Awaiting requested review from halter73

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

9.0-rc1

Development

Successfully merging this pull request may close these issues.

3 participants

@wtgodbe @JamesNK @javiercn