[release/9.0-preview7] Go back to checked-in minified .js files #56995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
ghost
added
the
area-infrastructure
rbhanda
added
Servicing-approved
wtgodbe
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #56982 to release/9.0-preview7
/cc @wtgodbe
Go back to checked-in minified .js files
Check the minified .js files from the NPM build back into the repo
Description
Our NPM build produces minified .js files that we ship in the SharedFx. We can't yet produce these in SourceBuild, because we don't have a robust solution for building our NPM components without restoring packages over the network. We tried a few things in 9 but nothing quite worked, so we are just going back to how we've always shipped before, which is having the latest versions of the files checked into the repo.
Fixes #56933 and dotnet/source-build#4149
Customer Impact
Unblocks our source build partners - we have been working closely with them on this for several months, and we think this is the best solution for 9.
Regression?
We tried many other solutions in 9 but nothing quite worked, so this is a regression from the 9.0 previews, but not from 8.
Risk
This just gets us back to the state we were in in 8 & earlier
Verification
Packaging changes reviewed?
When servicing release/2.1