Skip to content

Wordsmith pattern exhaustiveness #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2023
Merged

Wordsmith pattern exhaustiveness #963

merged 2 commits into from
Oct 4, 2023

Conversation

Nigel-Ecma
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma commented Oct 3, 2023 •
edited
Loading

Addresses #939

@Nigel-Ecma Nigel-Ecma added this to the Pre-C# 8.0 milestone Oct 3, 2023
jskeet
jskeet approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally happy - one suggestion.

BillWagner
BillWagner approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jskeet jskeet merged commit 5eb3b0b into dotnet:draft-v8 Oct 4, 2023
@jskeet jskeet mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

@BillWagner BillWagner BillWagner approved these changes

@RexJaeschke RexJaeschke RexJaeschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pre-C# 8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Nigel-Ecma @jskeet @BillWagner @RexJaeschke