Skip to content

Documentation incorrectly refers to DefaultItemExcludesInProjectFolder as DefaultExcludesInProjectFolder #30271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
binki opened this issue Jul 19, 2022 · 0 comments · Fixed by #30278

Comments

@binki
Copy link

binki commented Jul 19, 2022

The documentation states that DefaultExcludesInProjectFolder is a property I can set in my project files to append project-folder-specific item excludes. However, the actual property name is DefaultItemExcludesInProjectFolder.

In Microsoft.NET.Sdk.DefaultItems.targets, you can see how, while DefaultExcludesInProjectFolder is used for the internal implementation of DefaultItemExcludesInProjectFolder, it is completely ignored. The SDK only consumes the user-defined DefaultItemExcludesInProjectFolder instead.

This was later changed in dotnet/sdk@3b684c6 which causes sdk versions 7+ to also consume DefaultExcludesInProjectFolder. However, the latest stable release, 6.0.302, requires the user to specify DefaultItemExcludesInProjectFolder. I spent hours trying to figure out why the buildsystem was not complying with my request even though I was faithfully following the documentation carefully. I eventually traced through the framework code and arrived at Microsoft.NET.Sdk.DefaultItems.targets.

Please update the documentation to clearly state that DefaultItemExcludesInProjectFolder is the correct property name. Please also document the information in dotnet/sdk#24063 about how DefaultExcludesInProjectFolder only works in sdk 7+ and that, to support all versions, the only option is to use DefaultItemExcludesInProjectFolder instead.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants