Fix DefaultExcludesInProjectFolder value ignored #24063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DefaultItemExcludesInProjectFolder property is never defined and was highly likely forgotten to be renamed. Because of that, the DefaultExcludesInProjectFolder property overwrites any user set values.
ghost
added
the
|
This probably was a mistake, but I'm not sure about taking the change now, as it looks like there are projects setting the property that isn't otherwise set or used in the SDK: https://github.com/search?q=DefaultItemExcludesInProjectFolder&type=code |
|
What about excluding both |
dsplaisted
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DefaultItemExcludesInProjectFolderproperty is never defined and was likely forgotten to be renamed. Because of that, theDefaultExcludesInProjectFolderproperty overwrites any user set value. AddDefaultExcludesInProjectFolderand keepDefaultItemExcludesInProjectFolderto not break existing consumers.