Skip to content

Update property name for default item excludes #30278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

Update property name for default item excludes #30278

merged 1 commit into from
Jul 20, 2022

Conversation

gewarren
Copy link
Contributor

Fixes #30271.

@dotnet-bot dotnet-bot added this to the July 2022 milestone Jul 19, 2022
@gewarren gewarren requested review from ViktorHofer and a team July 19, 2022 22:29
ViktorHofer
ViktorHofer approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. We can revert this change in a few years when SDKs older than .NET 7 are out of support.

@IEvangelist IEvangelist merged commit 77924d1 into main Jul 20, 2022
@IEvangelist IEvangelist deleted the gewarren-patch-2 branch July 20, 2022 12:36
@gewarren gewarren added the okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Milestone
July 2022
Development

Successfully merging this pull request may close these issues.

Documentation incorrectly refers to DefaultItemExcludesInProjectFolder as DefaultExcludesInProjectFolder
4 participants
@gewarren @ViktorHofer @IEvangelist @dotnet-bot