Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jul 8, 2021

Fixes #24971

@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 8, 2021
@gewarren gewarren requested review from BillWagner and a team July 8, 2021 19:45
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from snippets 5000 warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete

@BillWagner
Copy link
Member

@gewarren @tdykstra The snippets 5000 should allow warnings.

I think the issue is this error:

D:\a\docs\docs\docs\fundamentals\code-analysis\quality-rules\snippets\csharp\all-rules\ca2208.cs(11,23): error CA2208: Method .ctor passes parameter name 'title' as the message argument to a ArgumentNullException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. 

@gewarren
Copy link
Contributor Author

gewarren commented Jul 9, 2021

I'm fixing up the warnings/errors in #25046.

@gewarren gewarren merged commit 3c2082e into main Jul 12, 2021
@gewarren gewarren deleted the gewarren-patch-3 branch July 12, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for init-only setter for CA2227: Collection properties should be read only
4 participants