Fix build warnings in CA snippets #25046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrabYourPitchforks Could you please review this since it involves removing code/verbiage around CAS? |
Youssef1313
reviewed
Jul 9, 2021
docs/fundamentals/code-analysis/quality-rules/snippets/csharp/all-rules/.editorconfig
Outdated
Show resolved
Hide resolved
BillWagner
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
This LGTM @gewarren
You can 
once @GrabYourPitchforks weighs in.
|
I have no problem with the verbiage change. However, it is important to note that CAS is well and truly dead, even on Full Framework. Rules like CA2109 no longer have meaning and IMO should be deleted from any static analysis package we provide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.