Skip to content

Resolving disposed service provider #26874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Nov 8, 2021

Fixes #26783

Preview

@gewarren gewarren requested review from maryamariyan and a team November 8, 2021 22:38
@dotnet-bot dotnet-bot added this to the November 2021 milestone Nov 8, 2021

## Affected APIs

- <xref:System.IServiceProvider.GetService(System.Type)?displayProperty=fullName>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the affected APIs - please double check.

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@gewarren gewarren merged commit da33359 into dotnet:main Nov 9, 2021
@gewarren gewarren deleted the disposed-exception branch November 9, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Breaking change]: Throw when resolving on a disposed service provider
3 participants