-
Notifications
You must be signed in to change notification settings - Fork 6k
Resolving disposed service provider #26874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
docs/core/compatibility/extensions/6.0/service-provider-disposed.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
--- | ||
title: "Breaking change: Resolving disposed ServiceProvider throws exception" | ||
description: Learn about the .NET 6 breaking change in .NET extensions where resolving a disposed service provider throws an exception. | ||
ms.date: 11/08/2021 | ||
--- | ||
# Resolving disposed ServiceProvider throws exception | ||
|
||
When a service is resolved after the service provider has been disposed, the affected methods now throw an <xref:System.ObjectDisposedException> instead of causing a deadlock. | ||
|
||
## Version introduced | ||
|
||
6.0 RC 1 | ||
|
||
## Previous behavior | ||
|
||
Previously, in the rare case that an application resolved a service after the service provider was disposed, it led to a deadlock. | ||
|
||
## New behavior | ||
|
||
Starting in .NET 6, an <xref:System.ObjectDisposedException> is thrown when a service is resolved after the service provider has been disposed, and there's no deadlock. | ||
|
||
## Type of breaking change | ||
|
||
This change can affect [source compatibility](../../categories.md#source-compatibility). | ||
|
||
## Reason for change | ||
|
||
This change was introduced to fix the deadlock scenario. | ||
|
||
## Recommended action | ||
|
||
Catch <xref:System.ObjectDisposedException> when calling any of the affected APIs. | ||
|
||
## Affected APIs | ||
|
||
- <xref:System.IServiceProvider.GetService(System.Type)?displayProperty=fullName> | ||
- <xref:Microsoft.Extensions.DependencyInjection.ISupportRequiredService.GetRequiredService(System.Type)?displayProperty=fullName> | ||
- <xref:Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(System.IServiceProvider,System.Type)?displayProperty=fullName> | ||
- <xref:Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService%60%601(System.IServiceProvider)?displayProperty=fullName> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the affected APIs - please double check.