Skip to content

Reword policheck issue #15915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2023
Merged

Reword policheck issue #15915

merged 3 commits into from
Sep 4, 2023

Conversation

KevinRansom
Copy link
Contributor

Policheck an automated tool that verifies text in shipped files against flagged the term: %A holes in the file FSharp.Core.xml as a profanity - this probably needs no further explanation.

I replaced the term with "%A expression gaps".

Thanks

@KevinRansom KevinRansom requested a review from a team as a code owner September 1, 2023 21:43
@smoothdeveloper
Copy link
Contributor

Looks doubleplusgood.

T-Gro
T-Gro approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye to %A holes then.

@T-Gro T-Gro merged commit 114ef07 into dotnet:main Sep 4, 2023
@allisonchou allisonchou mentioned this pull request Sep 7, 2023
Closed
@KevinRansom KevinRansom deleted the policheck branch March 14, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonie abonie abonie approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KevinRansom @smoothdeveloper @abonie @T-Gro