Skip to content

Reword policheck issue #15915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/debug-emit.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ The intended debug points for constructs are determined by syntax as follows. P

* The bodies of functions, methods, lambdas and initialization code for top-level-bindings are all processed as control flow

* Each CAPITAL-EXPR below is processed as control-flow (the bodies of loops, conditionals etc.)
* Each Upper-Cased EXPR below is processed as control-flow (the bodies of loops, conditionals etc.)

* Leaf expressions are the other composite expressions like applications that are not covered by the other constructs.

Expand Down
2 changes: 1 addition & 1 deletion release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -1118,7 +1118,7 @@ Contains commits from 32b124966 to d7018737c from dotnet/fsharp. Notable changes
* lowered allocations for several internal compiler structures
* better error messages for anonymous record mismatches
* FSharpChecker learned how to keep background symbol uses
* Project cracker/project cracker tool were removed
* The tool for parsing projects was removed
* Better support for consuming C# in-ref parameters
* new services around simplifying names and finding unused declarations
* package management in scripts (in preview)
Expand Down
2 changes: 1 addition & 1 deletion src/Compiler/Checking/CheckFormatStrings.fs
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ module internal Parse =
if p = None then None, fmtPos else p, pos'
| _ -> None, fmtPos

// Explicitly typed holes in interpolated strings "....%d{x}..." get additional '%P()' as a hole place marker
// Explicitly typed expression gaps in interpolated strings "....%d{x}..." get additional '%P()' as an expression gap place marker
let skipPossibleInterpolationHole isInterpolated isFormattableString (fmt: string) i =
let len = fmt.Length
if isInterpolated then
Expand Down
4 changes: 2 additions & 2 deletions src/FSharp.Core/printf.fsi
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type PrintfFormat<'Printer, 'State, 'Residue, 'Result> =
/// <summary>Construct a format string </summary>
/// <param name="value">The input string.</param>
/// <param name="captures">The captured expressions in an interpolated string.</param>
/// <param name="captureTys">The types of expressions for %A holes in interpolated string.</param>
/// <param name="captureTys">The types of expressions for %A expression gaps in interpolated string.</param>
/// <returns>The PrintfFormat containing the formatted result.</returns>
new: value: string * captures: obj[] * captureTys: Type[] -> PrintfFormat<'Printer, 'State, 'Residue, 'Result>

Expand Down Expand Up @@ -65,7 +65,7 @@ type PrintfFormat<'Printer, 'State, 'Residue, 'Result, 'Tuple> =
///
/// <param name="value">The input string.</param>
/// <param name="captures">The captured expressions in an interpolated string.</param>
/// <param name="captureTys">The types of expressions for %A holes in interpolated string.</param>
/// <param name="captureTys">The types of expressions for %A expression gaps in interpolated string.</param>
///
/// <returns>The created format string.</returns>
new:
Expand Down