-
Notifications
You must be signed in to change notification settings - Fork 825
Fix AOT #17238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix AOT #17238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
psfinaki
reviewed
May 24, 2024
T-Gro
reviewed
May 24, 2024
T-Gro
approved these changes
May 27, 2024
psfinaki
approved these changes
May 27, 2024
vzarytovskii
added a commit
that referenced
this pull request
May 29, 2024
This reverts commit 7e59327.
Merged
vzarytovskii
added a commit
that referenced
this pull request
May 29, 2024
KevinRansom
added a commit
that referenced
this pull request
May 31, 2024
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Jun 4, 2024
This reverts commit 53273d1.
This was referenced Jun 7, 2024
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Jun 8, 2024
This reverts commit 53273d1.
vzarytovskii
added a commit
that referenced
this pull request
Jun 21, 2024
Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Petr <[email protected]> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Brian Rourke Boll <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]> Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Florian Verdonck <[email protected]> Co-authored-by: Jakub Majocha <[email protected]> Co-authored-by: ijklam <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dawe <[email protected]> Co-authored-by: Tom Deseyn <[email protected]> Fix AOT (#17238)" (#17264) Fix full source-build product build when running R2R (#17259) Fix plain build of FSC fsproj (#17270) Fix #14375 by showing and inserting correct name of entities from unopened namespace/module (#17261) fix #14375 Fix a typo in docs (#17273) Fix sbom generation (#17275)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AOT tests built differently when run with cibuild.cmd compared to build.cmd.
This change ensures that the AOT tests build identically for each build command.