-
Notifications
You must be signed in to change notification settings - Fork 825
Fix #14375 by showing and inserting correct name of entities from unopened namespace/module #17261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❗ Release notes required
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Tangent-90 - thanks for another good contribution!
I get what the issue is about, yet for some reason, I cannot reproduce the exact problem described in the bug. This PR has a bit different setting though - so could I ask you to also record a small "before" gif, how things currently look on your machine?
Ideally we'd have some compiler service tests here as well - have you looked around there if there is something we can build on?
I have no other VS installation, so I record this GIF in VSCode (but it is the same bug). You can see that the class |
maybe we can add test to here |
Yeah, let's try those ones. Note they have just moved to the Compiler.Service project, but haven't changed otherwise. |
@Tangent-90 sorry it's taking this long - I am really trying my best to verify this. Among other things, it will be helpful when writing the release notes for VS. I have checked out your branch and I am trying to repro the last example you've shared but seems like I am still getting the incorrect behavior: Recording.2024-06-03.145038.mp4How does this look for you? And what could I be doing wrong? |
This pr is solving problem in completion list of unresolved symbols (press |
Okay fair enough, I was looking at the wrong place :) But now, hopefully, I am looking at the right place and still don't notice the change... Trying Ctrl + J here: Recording.2024-06-03.154513.mp4 |
Ohhhh I see now. Yeah that was it, now I see the difference. All good, thanks for the explanations and the testing! |
Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Petr <[email protected]> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Brian Rourke Boll <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]> Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Florian Verdonck <[email protected]> Co-authored-by: Jakub Majocha <[email protected]> Co-authored-by: ijklam <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dawe <[email protected]> Co-authored-by: Tom Deseyn <[email protected]> Fix AOT (#17238)" (#17264) Fix full source-build product build when running R2R (#17259) Fix plain build of FSC fsproj (#17270) Fix #14375 by showing and inserting correct name of entities from unopened namespace/module (#17261) fix #14375 Fix a typo in docs (#17273) Fix sbom generation (#17275)
Description
Extracted from #17252
Fixes part 2 of #14375
DisplayName
, so it won't try to open a class now. For modules, it will only try to open the nearest parent namespace/module.Checklist