Remove DOTNET_CLI_RUN_MSBUILD_OUTOFPROC=true from SdkTests.csproj

[akoeplinger]

It was added as part of #10185 (comment) but I don't think it should be there long term.

[akoeplinger]

@marcpopMSFT I probably lack the relevant context on the cli/msbuild interactions to properly fix the issue so I think the issue shouldn't be assigned to me, I mainly wanted to unblock the sdk bump PR :)

[marcpopMSFT]

@wli3 @dsplaisted I tried reverting the change but my local installer tests pass. Any idea how to reproduce the issue that was showing up in the original PR to investigate further?

[dsplaisted]

Were you running the test under localization? That's where the failure was.

[akoeplinger]

I was able to repro the issue on macOS by using DOTNET_CLI_UI_LANGUAGE=es LANG=es_ES ./build.sh -test --projects $PWD/test/SdkTests/SdkTests.csproj

[marcpopMSFT]

I was specifically trying to get it reproing when running tests in VS so I could debug through the issue. Daniel helped with that and I can reproduce the problem. The issue is that the SDK tests pull in the English strings but not the localized xlf. Neither Daniel or Will are familiar with how to add those localized strings into the test projects as none of our other tests do that today and our localization was done by other team members. I'll time-box this further but if I can't localize the tests, I will disable the ES PR leg in the installer repo as Will says it has not caught a failure in the last 3 years that it was running that he's aware of. We'll make up the coverage by asking the vendor team to execute a quick localization test on dotnet CLI during signoff.

Any concerns?

[marcpopMSFT]

Daniel gave me a pointer and I was able to generate loc resources for the publish tests. Unfortunately, stdout converted the double quotes from the ES xlif so there's a pretty hacky workaround for that but it lets us keep the loc testing leg if we want:
dotnet/sdk#17056