[main] Update dependencies from dotnet/sdk

[dotnet-maestro]

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

• Coherency Updates:
  • Microsoft.WindowsDesktop.App.Ref: from 6.0.0-preview.4.21206.2 to 6.0.0-preview.4.21212.1 (parent: Microsoft.NET.Sdk)
  • VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0: from 6.0.0-preview.4.21206.2 to 6.0.0-preview.4.21212.1 (parent: Microsoft.NET.Sdk)
  • VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3 (parent: Microsoft.NET.Sdk)
  • Microsoft.NETCore.App.Ref: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3 (parent: Microsoft.NET.Sdk)
  • Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3 (parent: Microsoft.NET.Sdk)
  • Microsoft.NETCore.App.Host.win-x64: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3 (parent: Microsoft.NET.Sdk)
  • Microsoft.NETCore.DotNetHostResolver: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3 (parent: Microsoft.NET.Sdk)
  • Microsoft.NETCore.Platforms: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3 (parent: Microsoft.NET.Sdk)
  • Microsoft.AspNetCore.App.Ref: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1 (parent: Microsoft.NET.Sdk)
  • Microsoft.AspNetCore.App.Ref.Internal: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1 (parent: Microsoft.NET.Sdk)
  • Microsoft.AspNetCore.App.Runtime.win-x64: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1 (parent: Microsoft.NET.Sdk)
  • VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1 (parent: Microsoft.NET.Sdk)
  • dotnet-dev-certs: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1 (parent: Microsoft.NET.Sdk)
  • dotnet-user-secrets: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1 (parent: Microsoft.NET.Sdk)
  • Microsoft.DotNet.Common.ItemTemplates: from 6.0.100-preview.4.21206.2 to 6.0.100-preview.4.21213.1 (parent: Microsoft.NET.Sdk)
  • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 6.0.0-preview.4.21206.2 to 6.0.0-preview.4.21212.1 (parent: Microsoft.NET.Sdk)
  • Microsoft.Dotnet.WinForms.ProjectTemplates: from 6.0.0-preview.4.21205.2 to 6.0.0-preview.4.21212.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
  • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 6.0.0-preview.4.21206.2 to 6.0.0-preview.4.21212.1 (parent: Microsoft.NET.Sdk)
  • Microsoft.DotNet.Wpf.ProjectTemplates: from 6.0.0-preview.4.21206.1 to 6.0.0-preview.4.21212.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
  • Microsoft.FSharp.Compiler: from 11.4.2-beta.21204.5 to 11.4.2-beta.21212.7 (parent: Microsoft.NET.Sdk)
  • Microsoft.NET.ILLink.Tasks: from 6.0.100-preview.2.21207.1 to 6.0.100-preview.2.21212.5 (parent: Microsoft.NET.Sdk)
  • Microsoft.Net.Compilers.Toolset: from 3.10.0-3.21208.2 to 3.10.0-3.21213.18 (parent: Microsoft.NET.Sdk)
  • NuGet.Build.Tasks: from 5.10.0-preview.2.7190 to 5.10.0-preview.2.7203 (parent: Microsoft.NET.Sdk)

From https://github.com/dotnet/sdk

• Subscription: f5e16d6d-e643-4370-f3ed-08d8e97c775d
• Build: 20210413.29
• Date Produced: 4/14/2021 6:07 AM
• Commit: 26d7fc3
• Branch: refs/heads/main

• Updates:
  • Microsoft.DotNet.MSBuildSdkResolver: from 6.0.100-preview.4.21207.25 to 6.0.100-preview.4.21213.29
  • Microsoft.NET.Sdk: from 6.0.100-preview.4.21207.25 to 6.0.100-preview.4.21213.29
  • Microsoft.WindowsDesktop.App.Ref: from 6.0.0-preview.4.21206.2 to 6.0.0-preview.4.21212.1
  • VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0: from 6.0.0-preview.4.21206.2 to 6.0.0-preview.4.21212.1
  • VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3
  • Microsoft.NETCore.App.Ref: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3
  • Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3
  • Microsoft.NETCore.App.Host.win-x64: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3
  • Microsoft.NETCore.DotNetHostResolver: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3
  • Microsoft.NETCore.Platforms: from 6.0.0-preview.4.21205.3 to 6.0.0-preview.4.21213.3
  • Microsoft.AspNetCore.App.Ref: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1
  • Microsoft.AspNetCore.App.Ref.Internal: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1
  • Microsoft.AspNetCore.App.Runtime.win-x64: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1
  • VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1
  • dotnet-dev-certs: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1
  • dotnet-user-secrets: from 6.0.0-preview.4.21207.16 to 6.0.0-preview.4.21213.1
  • Microsoft.DotNet.Common.ItemTemplates: from 6.0.100-preview.4.21206.2 to 6.0.100-preview.4.21213.1
  • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 6.0.0-preview.4.21206.2 to 6.0.0-preview.4.21212.1
  • Microsoft.Dotnet.WinForms.ProjectTemplates: from 6.0.0-preview.4.21205.2 to 6.0.0-preview.4.21212.1
  • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 6.0.0-preview.4.21206.2 to 6.0.0-preview.4.21212.1
  • Microsoft.DotNet.Wpf.ProjectTemplates: from 6.0.0-preview.4.21206.1 to 6.0.0-preview.4.21212.1
  • Microsoft.FSharp.Compiler: from 11.4.2-beta.21204.5 to 11.4.2-beta.21212.7
  • Microsoft.NET.ILLink.Tasks: from 6.0.100-preview.2.21207.1 to 6.0.100-preview.2.21212.5
  • Microsoft.Net.Compilers.Toolset: from 3.10.0-3.21208.2 to 3.10.0-3.21213.18
  • NuGet.Build.Tasks: from 5.10.0-preview.2.7190 to 5.10.0-preview.2.7203

[captainsafia]

It looks like this is blocked by dotnet/runtime#50979.

[sebastienros]

I think it makes sense that it doesn't pass since the sdk is trying to get the latest runtime, but it's breaking aspnet. So even more urgent to get this issue fixed.

[akoeplinger]

So we're seeing failures on the Spanish build leg, e.g.:

The command output did not contain expected result: NETSDK1125: Publishing to a single-file is only supported for netcoreapp target.

File Name: D:\workspace\_work\1\s\artifacts\bin\redist\Debug\dotnet-with-previous-runtimes\dotnet.exe
Arguments: msbuild /t:Publish D:\workspace\_work\1\s\artifacts\tmp\Debug\dotnetSdkTests\It_errors_whe---C21DC4D5\NetStandardExe\NetStandardExe.csproj /restore /p:PublishSingleFile=true /p:RuntimeIdentifier=win10-x64 /p:UseAppHost=true
Exit Code: 1
StdOut:
Microsoft (R) Build Engine versión 16.10.0-preview-21205-05+7804350cd para .NET
Copyright (C) Microsoft Corporation. Todos los derechos reservados.

  Determinando los proyectos que se van a restaurar...
  Se ha restaurado D:\workspace\_work\1\s\artifacts\tmp\Debug\dotnetSdkTests\It_errors_whe---C21DC4D5\NetStandardExe\NetStandardExe.csproj (en 261 ms).
  Está usando una versión preliminar de .NET. Consulte https://aka.ms/dotnet-core-preview
  NetStandardExe -> D:\workspace\_work\1\s\artifacts\tmp\Debug\dotnetSdkTests\It_errors_whe---C21DC4D5\NetStandardExe\bin\Debug\netstandard2.0\win10-x64\NetStandardExe.dll
D:\workspace\_work\1\s\artifacts\bin\redist\Debug\dotnet-with-previous-runtimes\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(99,5): error NETSDK1125: La publicación en un único archivo solo se admite para el destino netcoreapp. [D:\workspace\_work\1\s\artifacts\tmp\Debug\dotnetSdkTests\It_errors_whe---C21DC4D5\NetStandardExe\NetStandardExe.csproj]
StdErr:

The interesting bit is that the expected NETSDK1125 error is indeed there, just with a Spanish localized error message.

I found out that this happens because of this change which moved MSBuild.dll to be loaded in-proc rather than out-of-proc: dotnet/sdk#16577

In CI we're running on an English OS but force Spanish dotnet CLI output via DOTNET_CLI_UI_LANGUAGE=es:

installer/.vsts-ci.yml

Line 67 in a069111

_DOTNET_CLI_UI_LANGUAGE: es

This works for the tests in this repo because they have explicit code to force the DefaultThreadCurrentUICulture to match DOTNET_CLI_UI_LANGUAGE:

installer/test/Microsoft.DotNet.Tools.Tests.Utilities/TestBase.cs

Lines 29 to 34 in a069111

	// set culture of test process to match CLI sub-processes when the UI language is overriden.
	string overriddenUILanguage = Environment.GetEnvironmentVariable("DOTNET_CLI_UI_LANGUAGE");
	if (overriddenUILanguage != null)
	{
	CultureInfo.DefaultThreadCurrentUICulture = new CultureInfo(overriddenUILanguage);
	}

For the SdkTests.csproj tests though we're just running the tests from the SDK repo and that means the test thread that reads the expected string uses the OS language (== English) even though the started dotnet process will respect DOTNET_CLI_UI_LANGUAGE and output Spanish strings -> test fails.

I think the easiest solution to unblock this PR is to set DOTNET_CLI_RUN_MSBUILD_OUTOFPROC=true when running the SdkTests.csproj for now so we revert back to the old behavior, I'll push that to this PR.

/cc @dsplaisted @marcpopMSFT

[akoeplinger]

Files #10218 to track removing the workaround.