Modify GenerateLayout to work with runtime configs that contain more than one runtime #10901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this changed with dotnet/sdk#17982 |
dsplaisted
approved these changes
Jun 15, 2021
| { | ||
| var text = File.ReadAllText(file); | ||
| JObject config = JObject.Parse(text); | ||
| var frameworks = config["runtimeOptions"]?["frameworks"]; |
There was a problem hiding this comment.
If there is only one framework, it will be in the framework element instead of having a list in the frameworks:
Probably this task needs to handle both cases.
pranavkm
force-pushed
the
prkrishn/fixup-shared-runtime
branch
from
041f3cc to
4cbc873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent builds of dotnet-watch contain more than one runtime in the runtimconfig.json. This trips up the way RetargetTools currently works. Changing this to a bespoke task rather than one that finds-and-replaces text.