Modify GenerateLayout to work with runtime configs that contain more than one runtime (#10901) #10947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than one runtime (#10901)
|
Porting the change from main #10901 |
dsplaisted
approved these changes
Jun 22, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preview6, the runtimeconfig.json for dotnet-watch added a reference to Microsoft.NetCore.App in addition to the existing Microsoft.AspNetCore.App reference. As part of creating the installer, the build task stamps in exact versions of the shared runtimes. The current implementation has a bug where it stamps in the M.A.App version for all framework references in the runtime config. This causes the tool to fail loading.
Customer impact
Unable to run dotnet-watch.
Risk
Low - this change affects packaging and has been in main for a about a week now.
Testing
Manual testing
Fixes dotnet/aspnetcore#33739