Enable jit-analyze to take multiple metrics as input and add an option to output .md file #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tired of gathering the diff data for individual metric by invoking
jit-analyzemultiple times, so I went ahead and added ability to specify multiple metrics in comma-separated form so we can see the diffs of multiple metrics at one instead of invokingjit-analyzemultiple times. Another motivation was that I wanted to output the diff result in.mdfile so I can just copy the contents from it and paste it on GH. So I went ahead and added an option of--mdthat will output the diff result (of all the metrics specified) in an.mdfile.Example of what you end up getting in
.mdcan be seen in dotnet/runtime#47307 (comment).Contributes to #125