Skip to content

Fix "error: invalid option --metric" error #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2021
Merged

Fix "error: invalid option --metric" error #316

merged 1 commit into from
Feb 16, 2021

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Feb 15, 2021

jit-diff diff executes jit-analyze after running the diffs and always fail with error: invalid option --metric
I guess it was introduced in #312

AndyAyersMS
AndyAyersMS approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Suspect many folks have shifted over to using SPMI for diffs.

@sandreenko sandreenko merged commit e2d836e into dotnet:master Feb 16, 2021
@JulieLeeMSFT
Copy link
Member

I had this error too. Will use this fix.

@kunalspathak
Copy link
Contributor

Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EgorBo @JulieLeeMSFT @kunalspathak @AndyAyersMS @sandreenko