Skip to content

Rename weights parameter in ML.NET Public API #2257

New issue
New issue
Closed
Closed
Rename weights parameter in ML.NET Public API#2257
Assignees
abgoswam
Labels
APIIssues pertaining the friendly API
Milestone
 
0219
@abgoswam

Description

@abgoswam
abgoswam
opened on Jan 27, 2019 · edited by abgoswam

Couple of conventions to follow for weights parameter in ML.NET Public API

  • Name of the weight argument in trainer API should be consistent with the other column names i.e it should end on *Column.
  • Proposal to disambiguate this by calling it exampleWeightColumn.

@glebuk

Activity

abgoswam
added
APIIssues pertaining the friendly API
on Jan 27, 2019
abgoswam
self-assigned this
on Jan 27, 2019
abgoswam
mentioned this on Jan 27, 2019
ghost

ghost commented on Jan 28, 2019

@ghost
ghost
on Jan 28, 2019

Hi is this up for grabs?

abgoswam

abgoswam commented on Jan 28, 2019

@abgoswam
abgoswam
on Jan 28, 2019 · edited by abgoswam
MemberAuthor

@daniel-loudon . This relates to the public API of ML.NET , and needs to be done consistently for ~30 learners. Not labeled up-for-grabs -- I am currently working on this and will have a PR out for this shortly.

abgoswam
mentioned this on Feb 21, 2019
shauheen
added this to the 0219 milestone on Feb 21, 2019
abgoswam
closed this as completedin #2665on Feb 25, 2019
Ivanidzo4ka
mentioned this on Mar 6, 2019
ghost locked as resolved and limited conversation to collaborators on Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

APIIssues pertaining the friendly API

Type

No type

Projects

No projects

Milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @shauheen@abgoswam

      Issue actions
        Rename `weights` parameter in ML.NET Public API · Issue #2257 · dotnet/machinelearning