Skip to content

Rename weights parameter in ML.NET Public API #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abgoswam opened this issue Jan 27, 2019 · 2 comments
Closed

Rename weights parameter in ML.NET Public API #2257

abgoswam opened this issue Jan 27, 2019 · 2 comments
Assignees
@abgoswam
Labels
API Issues pertaining the friendly API
Milestone
0219

Comments

@abgoswam
Copy link
Member

abgoswam commented Jan 27, 2019 •
edited
Loading

Couple of conventions to follow for weights parameter in ML.NET Public API

  • Name of the weight argument in trainer API should be consistent with the other column names i.e it should end on *Column.
  • Proposal to disambiguate this by calling it exampleWeightColumn.

@glebuk
@abgoswam abgoswam added the API Issues pertaining the friendly API label Jan 27, 2019
@abgoswam abgoswam self-assigned this Jan 27, 2019
@abgoswam abgoswam mentioned this issue Jan 27, 2019
Closed
@ghost
Copy link

ghost commented Jan 28, 2019

Hi is this up for grabs?

@abgoswam
Copy link
Member Author

abgoswam commented Jan 28, 2019 •
edited
Loading

@daniel-loudon . This relates to the public API of ML.NET , and needs to be done consistently for ~30 learners. Not labeled up-for-grabs -- I am currently working on this and will have a PR out for this shortly.

This was referenced Feb 20, 2019
Closed
Merged
Closed
@shauheen shauheen added this to the 0219 milestone Feb 21, 2019
@Ivanidzo4ka Ivanidzo4ka mentioned this issue Mar 6, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abgoswam abgoswam

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0219
Development

No branches or pull requests
2 participants
@shauheen @abgoswam