Skip to content

Incorrect naming of Options argument in TensorFlowTransform public api #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abgoswam opened this issue Feb 3, 2019 · 0 comments
Closed

Incorrect naming of Options argument in TensorFlowTransform public api #2391

abgoswam opened this issue Feb 3, 2019 · 0 comments
Assignees
@abgoswam
Labels
API Issues pertaining the friendly API

Comments

@abgoswam
Copy link
Member

abgoswam commented Feb 3, 2019 •
edited
Loading

In PR : #2312 we modified the public surface of the TensorFlowTransform as per issue #1798 #2280

There is a bug - we did not rename the 'args' parameter. It should be 'options' (else it breaks consistency with rest of public surface)

machinelearning/src/Microsoft.ML.TensorFlow/TensorflowCatalog.cs

Lines 53 to 54 in 5b98e0c

public static TensorFlowEstimator TensorFlow(this TransformsCatalog catalog,
TensorFlowTransformer.Options args)

@ganik
@abgoswam abgoswam self-assigned this Feb 3, 2019
@abgoswam abgoswam mentioned this issue Feb 3, 2019
Merged
@abgoswam abgoswam added the API Issues pertaining the friendly API label Feb 3, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abgoswam abgoswam

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abgoswam