Skip to content

Lockdown Microsoft.ML.TensorFlow public surface #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 1, 2019
Merged

Lockdown Microsoft.ML.TensorFlow public surface #2312

merged 11 commits into from
Feb 1, 2019

Conversation

ganik
Copy link
Member

@ganik ganik commented Jan 29, 2019

fixes #2280

@codecov
Copy link

codecov bot commented Jan 29, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e356709). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2312   +/-   ##
=========================================
  Coverage          ?   71.14%           
=========================================
  Files             ?      779           
  Lines             ?   140271           
  Branches          ?    16046           
=========================================
  Hits              ?    99791           
  Misses            ?    36029           
  Partials          ?     4451
Flag Coverage Δ
#Debug 71.14% <100%> (?)
#production 67.56% <100%> (?)
#test 85.06% <ø> (?)

@Ivanidzo4ka Ivanidzo4ka requested review from Ivanidzo4ka, sfilipi and TomFinley and removed request for Ivanidzo4ka January 29, 2019 23:49
@sfilipi
Copy link
Member

sfilipi commented Jan 30, 2019 •
edited by ganik
Loading 

public sealed class TensorFlowEstimator : IEstimator<TensorFlowTransformer>

add one line of XML documentaiton to the types/members that are left public. #Resolved

Refers to: src/Microsoft.ML.TensorFlow/TensorflowTransform.cs:1083 in d1abbb8. [](commit_id = d1abbb8, deletion_comment = False)

@sfilipi
Copy link
Member

sfilipi commented Jan 30, 2019 •
edited by ganik
Loading 

/// <include file='doc.xml' path='doc/members/member[@name="TensorflowTransformer"]/*' />

would the text in the doc apply to the estimator and the extension methods? #Resolved

Refers to: src/Microsoft.ML.TensorFlow/TensorflowTransform.cs:37 in d1abbb8. [](commit_id = d1abbb8, deletion_comment = False)

@sfilipi
Copy link
Member

sfilipi commented Jan 30, 2019 •
edited by ganik
Loading 

    public sealed class Arguments : TransformInputBase

this can be internal too. #WontFix

Refers to: src/Microsoft.ML.TensorFlow/TensorflowTransform.cs:40 in d1abbb8. [](commit_id = d1abbb8, deletion_comment = False)

@sfilipi
Copy link
Member

sfilipi commented Jan 30, 2019 •
edited by ganik
Loading 

    internal TFGraph Graph => Session.Graph;

can any of those be of interest to the user, for retrieving info? #WontFix

Refers to: src/Microsoft.ML.TensorFlow/TensorflowTransform.cs:149 in d1abbb8. [](commit_id = d1abbb8, deletion_comment = False)

sfilipi
sfilipi approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@artidoro artidoro mentioned this pull request Jan 31, 2019
Closed
@ganik
Copy link
Member Author

ganik commented Jan 31, 2019 

    public sealed class Arguments : TransformInputBase

its used on public constructor so has to be public

In reply to: 458827501 [](ancestors = 458827501)

Refers to: src/Microsoft.ML.TensorFlow/TensorflowTransform.cs:40 in d1abbb8. [](commit_id = d1abbb8, deletion_comment = False)

@ganik
Copy link
Member Author

ganik commented Jan 31, 2019 

    internal TFGraph Graph => Session.Graph;

it will need a special presentation method then, as it is the internals of this object are not simple to understand

In reply to: 458827750 [](ancestors = 458827750)

Refers to: src/Microsoft.ML.TensorFlow/TensorflowTransform.cs:149 in d1abbb8. [](commit_id = d1abbb8, deletion_comment = False)

@ganik
Copy link
Member Author

ganik commented Jan 31, 2019 

/// <include file='doc.xml' path='doc/members/member[@name="TensorflowTransformer"]/*' />

no, only to Trasnformer

In reply to: 458827454 [](ancestors = 458827454)

Refers to: src/Microsoft.ML.TensorFlow/TensorflowTransform.cs:37 in d1abbb8. [](commit_id = d1abbb8, deletion_comment = False)

Ivanidzo4ka
Ivanidzo4ka reviewed Feb 1, 2019
View reviewed changes
src/Microsoft.ML.TensorFlow/TensorflowCatalog.cs
/// Score or Retrain a tensorflow model (based on setting of the <see cref="TensorFlowTransformer.Arguments.ReTrain"/>) setting.
/// The model is specified in the <see cref="TensorFlowTransformer.Arguments.ModelLocation"/>.
/// Score or Retrain a tensorflow model (based on setting of the <see cref="TensorFlowTransformer.Options.ReTrain"/>) setting.
/// The model is specified in the <see cref="TensorFlowTransformer.Options.ModelLocation"/>.
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka Feb 1, 2019 •
edited by ganik
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Options [](start = 75, length = 7)

Please rerun locally RegenerateEntryPointCatalog and upload changes in core_ep-list.tsv to this PR. #Resolved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

In reply to: 253190931 [](ancestors = 253190931)

Ivanidzo4ka
Ivanidzo4ka approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Ivanidzo4ka
Ivanidzo4ka reviewed Feb 1, 2019
View reviewed changes
test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs Outdated
@@ -433,7 +433,7 @@ public void TensorFlowTransformMNISTLRTrainingTest()

var pipe = mlContext.Transforms.Categorical.OneHotEncoding("OneHotLabel", "Label")
.Append(mlContext.Transforms.Normalize(new NormalizingEstimator.MinMaxColumn("Features", "Placeholder")))
.Append(new TensorFlowEstimator(mlContext, new TensorFlowTransformer.Arguments()
.Append(new TensorFlowEstimator(mlContext, new TensorFlowTransformer.Options()
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka Feb 1, 2019 •
edited by ganik
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TensorFlowEstimator [](start = 32, length = 19)

If you look on other peoples PR, i think we tend to change direct calls to estimators to mlContext.Transforms.TensorFlow #Resolved

@ganik ganik merged commit 69843b9 into dotnet:master Feb 1, 2019
@abgoswam abgoswam mentioned this pull request Feb 3, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

@sfilipi sfilipi sfilipi approved these changes

@TomFinley TomFinley Awaiting requested review from TomFinley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lockdown Microsoft.ML.TensorFlow public surface
3 participants
@ganik @sfilipi @Ivanidzo4ka