-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Adding defaults for Label and GroupId to Ranking Evaluator #2684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding defaults for Label and GroupId to Ranking Evaluator #2684
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2684 +/- ##
==========================================
- Coverage 71.54% 71.54% -0.01%
==========================================
Files 800 800
Lines 141827 141827
Branches 16119 16119
==========================================
- Hits 101472 101470 -2
- Misses 35913 35915 +2
Partials 4442 4442
|
@safern do you know what the magic is to make all the legs show up above in github, like they do now in CoreFX, rather than just one meta leg "MachineLearning-CI" |
We need to change the connection settings in the build definition itself. That will also enable comment triggers for this repo. @eerhardt @shauheen I can take care of that, I think using the new connection setting is worth it as it also gets a lot of fixes from the azure devops CI team. However, it adds an extra step to get to the builds. When you click on details, it sends you to the checks tab in GH. |
I'm not sure if we need anything different than what we have today... I feel I'm productive in the current environment. But if others feel it is valuable to have something different, I won't object unless I think that something different is worse than what we have today. |
To just feel the difference you can go into a corefx PR and look at the builds, click on one of them and try to navigate to it, etc. |
Yea, that experience is worse IMO. |
Yeah, but I think is getting cool feature, like retrying a single job, rather than the whole pipeline, and comment triggers, optional builds triggered by comments, etc. Stuff corefx did require. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds default column names for Label and GroupId for the Ranking
Evaluator
, in line with all other Evaluators.Fixes #2633