Skip to content

Normalizers multicolumn samples #3436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sfilipi opened this issue Apr 19, 2019 · 2 comments
Open

Normalizers multicolumn samples #3436

sfilipi opened this issue Apr 19, 2019 · 2 comments
Labels
documentation Related to documentation of ML.NET nit Needs a really small fix P3 Doc bugs, questions, minor issues, etc. up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@sfilipi
Copy link
Member

sfilipi commented Apr 19, 2019 •
edited
Loading

All transform extension APIs have been documented as part of #1209.
The only samples left to be created are the ones about normalizer extensions operating on multiple columns.

Replicate PR #3435 for the other normalizer APIs
@sfilipi sfilipi added documentation Related to documentation of ML.NET nit Needs a really small fix up-for-grabs A good issue to fix if you are trying to contribute to the project labels Apr 19, 2019
@shmoradims shmoradims added the P1 Priority of the issue for triage purpose: Needs to be fixed soon. label May 21, 2019
@Akshive
Copy link

Akshive commented Aug 14, 2019

I would like to work on this, but I need help to start as I am new to open source world.

@jwood803 jwood803 mentioned this issue Jan 11, 2020
Merged
@najeeb-kazmi najeeb-kazmi added P3 Doc bugs, questions, minor issues, etc. and removed P1 Priority of the issue for triage purpose: Needs to be fixed soon. labels Jan 17, 2020
@jwood803
Copy link
Contributor

jwood803 commented May 6, 2020 •
edited
Loading

From what I can tell these are all the normalizers and if they are have a multi column sample:

Normalizer Has Multi Column Sample?
Normalize Binning ✓
Normalize Global Contrast
Normalize Log Mean Variance
Normalize LP Norm
Normalize Mean Variance
Normalize MinMax ✓
Normalize Supervised Binning

The NormalizeGlobalContrast and NormalizeLpNorm normalizers don't seem to have an overload to take in an array of InputOutputColumnPair

I'll try to keep this updated as new PRs for this are merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Related to documentation of ML.NET nit Needs a really small fix P3 Doc bugs, questions, minor issues, etc. up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jwood803 @najeeb-kazmi @shmoradims @sfilipi @Akshive