NormalizeMinMax Multicolumn example #4644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natke
reviewed
Jan 14, 2020
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/NormalizeMinMaxMulticolumn.cs
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/NormalizeMinMaxMulticolumn.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/NormalizeMinMaxMulticolumn.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/NormalizeMinMaxMulticolumn.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/NormalizeMinMaxMulticolumn.cs
Outdated
Show resolved
Hide resolved
| // 0.0000, 0.0000, 0.3333, 0.0000 0.6667, 1.0000, 1.0000 | ||
| // -0.5000, -0.5000, -0.3333, 1.0000 1.0000, 0.0000, 0.5000 | ||
|
|
||
| // Let's get transformation parameters. Since we work with only one |
There was a problem hiding this comment.
Since we work with only one -> Since there is only one
There was a problem hiding this comment.
Don't we have two columns here? Features and Features2?
There was a problem hiding this comment.
Updated the wording of the comment, but I'll need to see how the formula changes since there are two columns instead of one.
Codecov Report
@@ Coverage Diff @@
## master #4644 +/- ##
=======================================
Coverage 75.84% 75.84%
=======================================
Files 947 947
Lines 172170 172170
Branches 18576 18576
=======================================
Hits 130585 130585
Misses 36416 36416
Partials 5169 5169
|
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/NormalizeMinMaxMulticolumn.cs
Show resolved
Hide resolved
|
@jwood803 please pull master, so that you have this commit. Then the tests that fail randomly should pass, so we can merge your PR. |
najeeb-kazmi
approved these changes
Feb 4, 2020
|
@natke does this look good to you? If so, let's try to merge this before release so that the example shows up in the docs. |
natke
approved these changes
Feb 5, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for #3436 for the NormalizeMinMax transform.
@sfilipi Took a shot at adding a multicolumn sample. If this is on the right track, I can help with some of the others.