Skip to content

Normalizer multicolumn example #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

sfilipi
Copy link
Member

@sfilipi sfilipi commented Apr 19, 2019

Adding a sample for the bin normalizer multicolumn extenion.

@sfilipi sfilipi self-assigned this Apr 19, 2019
@sfilipi sfilipi added the documentation Related to documentation of ML.NET label Apr 19, 2019
@sfilipi
Copy link
Member Author

sfilipi commented Apr 19, 2019

@shmoradims, @Ivanidzo4ka @natke how do you feel about leaving this samples simple?
The other overload has a ton more information, but maybe there is no need to duplicate all of that?

@glebuk glebuk self-requested a review April 19, 2019 07:12
@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@082ab77). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3435   +/-   ##
=========================================
  Coverage          ?   72.72%           
=========================================
  Files             ?      807           
  Lines             ?   145206           
  Branches          ?    16230           
=========================================
  Hits              ?   105608           
  Misses            ?    35179           
  Partials          ?     4419
Flag Coverage Δ
#Debug 72.72% <ø> (?)
#production 68.27% <ø> (?)
#test 88.98% <ø> (?)
Impacted Files Coverage Δ
src/Microsoft.ML.Transforms/NormalizerCatalog.cs 84.78% <ø> (ø)

Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shmoradims
Copy link

shmoradims commented Apr 19, 2019

@shmoradims, @Ivanidzo4ka @natke how do you feel about leaving this samples simple?
The other overload has a ton more information, but maybe there is no need to duplicate all of that?

Let's not spend time creating new samples. Our sample coverage is close to 100%. We just have to make sure the existing samples from people on vacation are checked in properly.

@shmoradims shmoradims merged commit ea5c095 into dotnet:master Apr 19, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Related to documentation of ML.NET
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants