Skip to content

Main package has MKL dependency #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danmoseley opened this issue Aug 23, 2018 · 4 comments
Closed

Main package has MKL dependency #721

danmoseley opened this issue Aug 23, 2018 · 4 comments
Assignees
@artidoro
Labels
Build Build related issue

Comments

@danmoseley
Copy link
Member

Microsoft.ML.Runtime.Data in the main package has WhiteningTransform which uses exports of MKL. If we want to segregate MKL users into Microsoft.ML.HalLearners then WhiteningTransform may need to move into an assembly in that package.

@eerhardt
@Ivanidzo4ka
Copy link
Contributor

@eerhardt
Only slightly related.
Why in our HalLearners package we have runtime folder with win-x64 only binaries?
Why it doesn't contain OSX and Linux binaries?
I've tried to look for documentation, but couldn't find anything.

@eerhardt
Copy link
Member

Why in our HalLearners package we have runtime folder with win-x64 only binaries?
Why it doesn't contain OSX and Linux binaries?

I looked at both https://www.nuget.org/packages/Microsoft.ML.HalLearners/0.4.0 and https://dotnet.myget.org/feed/dotnet-core/package/nuget/Microsoft.ML.HalLearners/0.5.0-preview-26823-1 and they both have assets under runtimes\linux-x64 and runtimes\osx-x64.

@Ivanidzo4ka Ivanidzo4ka added the Build Build related issue label Oct 19, 2018
@Ivanidzo4ka
Copy link
Contributor

DRI RESPONSE: Still valid. @artidoro suppose to properly convert Whitening to Estimator/Transformer and maybe he can also move it.

@artidoro artidoro mentioned this issue Oct 20, 2018
Closed
@artidoro artidoro mentioned this issue Oct 30, 2018
Merged
@artidoro artidoro reopened this Nov 8, 2018
@artidoro artidoro mentioned this issue Nov 8, 2018
Merged
@Zruty0 Zruty0 closed this as completed Nov 13, 2018
@eerhardt eerhardt reopened this Nov 13, 2018
@eerhardt
Copy link
Member

This isn't fixed yet. The PR to fix it hasn't been merged yet.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@artidoro artidoro

Labels
Build Build related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Conversion of Whitening Transform to estimator with pigstensions artidoro/machinelearning
5 participants
@Ivanidzo4ka @danmoseley @eerhardt @artidoro @Zruty0