WIP: Conversion of Whitening Transform to estimator with pigstensions #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Ivanidzo4ka
reviewed
Oct 20, 2018
| @@ -35,12 +43,12 @@ public enum WhiteningKind | |||
| } | |||
|
|
|||
| /// <include file='doc.xml' path='doc/members/member[@name="Whitening"]/*'/> | |||
| public sealed class WhiteningTransform : OneToOneTransformBase | |||
| public sealed class WhiteningTransform : OneToOneTransformerBase | |||
There was a problem hiding this comment.
WhiteningTransform [](start = 24, length = 18)
Tests please.
Ivanidzo4ka
reviewed
Oct 20, 2018
| string inputColumn, | ||
| string outputColumn = null, | ||
| WhiteningKind kind = WhiteningKind.Zca, | ||
| float eps = (float)1e-5, |
There was a problem hiding this comment.
(float)1e-5 [](start = 24, length = 11)
defaults class, s'll vous plait
Ivanidzo4ka
reviewed
Oct 20, 2018
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using Microsoft.ML.Core.Data; |
There was a problem hiding this comment.
please use git mv instead of copying files around.
wschin
reviewed
Oct 25, 2018
| /// <summary> | ||
| /// Extensions for statically typed Whitening estimator. | ||
| /// </summary> | ||
| public static class WhiteningExtensions |
There was a problem hiding this comment.
Do you want to put this into another file?
Ivanidzo4ka
reviewed
Oct 30, 2018
| @@ -0,0 +1,8 @@ | |||
| #@ TextLoader{ | |||
There was a problem hiding this comment.
TextLoader [](start = 3, length = 10)
Let's put this file into Common/Text/ instead of two versions of same file in Single/Text/
Ivanidzo4ka
reviewed
Oct 30, 2018
| @@ -772,89 +771,5 @@ public void PrincipalComponentAnalysis() | |||
| var type = schema.GetColumnType(pcaCol); | |||
| Assert.True(type.IsVector && type.IsKnownSizeVector && type.ItemType.IsNumber); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void NAIndicatorStatic() | |||
There was a problem hiding this comment.
NAIndicatorStatic [](start = 20, length = 17)
What happened here?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing work on converting the transformers to estimators (#754). This PR completes the conversion of the Whitening transform to estimator (previously a TrainedWrapperEstimator).
This also fixes #721.