Moved WhiteningTransform to HalLearners #1583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfilipi
reviewed
Nov 8, 2018
| /// <param name="eps">Whitening constant, prevents division by zero.</param> | ||
| /// <param name="maxRows">Maximum number of rows used to train the transform.</param> | ||
| /// <param name="pcaNum">In case of PCA whitening, indicates the number of components to retain.</param> | ||
| public static VectorWhiteningEstimator VectorWhiten(this TransformsCatalog.ProjectionTransforms catalog, string inputColumn, string outputColumn, |
There was a problem hiding this comment.
VectorWhiten [](start = 47, length = 12)
do you feel like writing a sample for it, and referencing it from here? :)
There was a problem hiding this comment.
Good point! I'll do that :)
|
@artidoro Can you merge it with master and merge it in eventually? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #721.
Moved the whitening transform file to HalLearners. Also had to move the corresponding mlcontext extensions.