move regex to right place to reduce test time #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singlis
approved these changes
Oct 26, 2018
Anipik
suggested changes
Oct 26, 2018
| @@ -59,6 +59,7 @@ protected BaseTestBaseline(ITestOutputHelper output) : base(output) | |||
| private const string OutputRootUnixRegExp = @"\/[^\\\t ]+\/TestOutput" + @"\/[^\\\t ]+"; | |||
| private static readonly string BinRegUnixExp = @"\/[^\\\t ]+\/bin\/" + Mode; | |||
| private static readonly string Bin64RegUnixExp = @"\/[^\\\t ]+\/bin\/x64\/" + Mode; | |||
| private static readonly Regex MatchNumbers = new Regex(@"\b[0-9]+\.?[0-9]*(E-[0-9]*)?\b", RegexOptions.IgnoreCase | RegexOptions.Compiled); | |||
There was a problem hiding this comment.
The regex is wrong , you left the negative sign. Can you please correct it ? #Closed
added 2 commits
October 25, 2018 17:25
safern
approved these changes
Oct 26, 2018
artidoro
approved these changes
Oct 26, 2018
artidoro
reviewed
Oct 26, 2018
| Regex _matchNumer = new Regex(@"-?\b[0-9]+\.?[0-9]*(E-[0-9]*)?\b", RegexOptions.IgnoreCase | RegexOptions.Compiled); | ||
| MatchCollection firstCollection = _matchNumer.Matches(firstString); | ||
| MatchCollection secondCollection = _matchNumer.Matches(secondString); | ||
|
|
There was a problem hiding this comment.
Could you remove the extra line?
This was referenced Oct 26, 2018
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1382 fixes #1348