Let's not create regex for every function call. #1384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanidzo4ka
commented
Oct 25, 2018
| @@ -504,16 +504,17 @@ protected bool CheckEqualityFromPathsCore(string relPath, string basePath, strin | |||
| } | |||
| } | |||
|
|
|||
| private static Regex MatchNumbers = new Regex(@"\b[0-9]+\.?[0-9]*(E-[0-9]*)?\b", RegexOptions.IgnoreCase | RegexOptions.Compiled); | |||
There was a problem hiding this comment.
make it readonly.
sfilipi
approved these changes
Oct 25, 2018
eerhardt
approved these changes
Oct 25, 2018
|
@Anipik let's see whose tests get finished first :D |
safern
approved these changes
Oct 25, 2018
|
Sorry, I've create this PR on top of branch in this repo, so now it's a bit tricky to modify. So I rather create new PR with branch in my fork and close this one. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this would speed up our tests?
#1382
#1348