Public API for Tree predictors #1837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ourceCode, ICanSaveSummary, ICanSaveSummaryInKeyValuePairs, and ICanGetSummaryAsIRow
najeeb-kazmi
requested review from
Ivanidzo4ka,
wschin,
TomFinley,
sfilipi and
Zruty0
sfilipi
reviewed
Dec 6, 2018
sfilipi
reviewed
Dec 6, 2018
…ntileValueMapper, IQuantileRegressionPredictor. Rename FastTreePredictionWrapper to TreeEnsembleModelParameters and all descendants to XyzModelParameters
najeeb-kazmi
changed the title
sfilipi
reviewed
Dec 11, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/FastTreeRegression.cs
Outdated
Show resolved
Hide resolved
sfilipi
reviewed
Dec 11, 2018
sfilipi
reviewed
Dec 11, 2018
| @@ -467,12 +467,12 @@ private static VersionInfo GetVersionInfo() | |||
|
|
|||
| protected override uint VerCategoricalSplitSerialized => 0x00010005; | |||
|
|
|||
| internal FastTreeRegressionPredictor(IHostEnvironment env, TreeEnsemble trainedEnsemble, int featureCount, string innerArgs) | |||
There was a problem hiding this comment.
internal [](start = 8, length = 8)
i still think those should be internal. There is nothing else that can create the predictor/model params besides training..
Only the class needs to be public IMO.. but I won't block on it.. you can take it with Tom/Pete and potentially change on a later PR.
There was a problem hiding this comment.
Makes sense. I'll keep these constructors public for now.
sfilipi
reviewed
Dec 11, 2018
wschin
reviewed
Dec 11, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/FastTreeRegression.cs
Outdated
Show resolved
Hide resolved
wschin
reviewed
Dec 11, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/FastTreeRegression.cs
Outdated
Show resolved
Hide resolved
wschin
reviewed
Dec 11, 2018
wschin
approved these changes
Dec 11, 2018
Ivanidzo4ka
reviewed
Dec 11, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/FastTreeRegression.cs
Outdated
Show resolved
Hide resolved
Ivanidzo4ka
reviewed
Dec 11, 2018
| // Get the leaf and the leaf value for a row of data with Parity = 1, Induced = 1 in the first tree. | ||
| var testRow = new VBuffer<float>(2, new[] { 1.0f, 1.0f }); | ||
| List<int> path = default; | ||
| var leaf = modelParams.GetLeaf(0, in testRow, ref path); |
There was a problem hiding this comment.
var leaf = modelParams.GetLeaf(0, in testRow, ref path); [](start = 12, length = 56)
How many leaves you have in this tree?
If it's only few, can we actually read all leaf values, and also their relationship and drew small tree in comments?
like
(node 0, value: 1.1)
|(left)
|---->(leaf 0, value: 2.4)
|
|(right)
|---> (leaf 1,value: 3.5)
Ivanidzo4ka
reviewed
Dec 11, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/FastTreeRegression.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1701
Internalized and explicitly implemented the following interfaces implemented by
FastTreePredictionWrapper:ICanSaveInIniFormatICanSaveInSourceCodeICanSaveSummaryICanSaveSummaryInKeyValuePairsICanGetSummaryAsIRowIFeatureContributionMapperIQuantileValueMapperIQuantileRegressionPredictorIValueMapperDistRenamed
FastTreePredictionWrappertoTreeEnsembleModelParametersand descendants toXYZModelParameters. Reduced public surface ofTreeEnsembleModelParametersand descendants.Added public constructors for
TreeEnsembleModelParametersand descendants.Added a sample showing
FastTreeRegressionModelParametersoperations.