Fix disabled code coverage for src folder. #2259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
approved these changes
Jan 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #2259 +/- ##
===========================================
- Coverage 80.82% 69.86% -10.96%
===========================================
Files 159 786 +627
Lines 28540 144082 +115542
Branches 1909 16622 +14713
===========================================
+ Hits 23068 100666 +77598
- Misses 5175 38869 +33694
- Partials 297 4547 +4250
|
sfilipi
approved these changes
Jan 28, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like #2200 broke code coverage for src folder, hence production coverage is not being generated and even the codecov badge on the main isn't displaying any coverage.
fixes #2258