Removed python naming conventions from samples - closes #2155 #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you @daniel-loudon |
Codecov Report
@@ Coverage Diff @@
## master #2303 +/- ##
==========================================
- Coverage 71.16% 71.14% -0.02%
==========================================
Files 780 779 -1
Lines 140338 140208 -130
Branches 16043 16019 -24
==========================================
- Hits 99866 99748 -118
+ Misses 36021 36020 -1
+ Partials 4451 4440 -11
|
sfilipi
approved these changes
Jan 29, 2019
|
I am having issues with fetching from my upstream. Nothing is being fetched. And then after I sync, everything I expected to be fetched is ready to be pushed. Is it because I am doing a pull request from my master? Is there any way I can do the merge changes on here and then commit it and try sort out the issues with my fork |
|
Yep. I have had issues with visual studio and fetching from this repository. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2155 - C# samples should use C# naming conventions and not python naming conventions. Second PR on this issue because last PR had issues