Skip to content

Lockdown Microsoft.ML.PCA public surface #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Lockdown Microsoft.ML.PCA public surface #2374

wants to merge 5 commits into from

Conversation

ganik
Copy link
Member

@ganik ganik commented Feb 1, 2019

fixes #2275

ganik and others added 4 commits January 29, 2019 14:24

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Merge

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Merge

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Merge
@Ivanidzo4ka
Copy link
Contributor

    public const string LoaderSignature = "PcaTransform";

internal


Refers to: src/Microsoft.ML.PCA/PcaTransformer.cs:227 in 5ac94da. [](commit_id = 5ac94da, deletion_comment = False)

using System.Runtime.CompilerServices;
using Microsoft.ML;

[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Tests" + PublicKey.TestValue)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PublicKey [](start = 67, length = 9)

if you change PcaTests.cs to use ml.Transforms.Projection.ProjectToPrincipalComponents instead of direct estimator call would you still need this change?

@sfilipi
Copy link
Member

sfilipi commented Feb 1, 2019

    public class Column : OneToOneColumn

internal


Refers to: src/Microsoft.ML.PCA/PcaTransformer.cs:60 in b54ce70. [](commit_id = b54ce70, deletion_comment = False)

@sfilipi
Copy link
Member

sfilipi commented Feb 1, 2019

        public readonly int? Seed;

one line XML

can borrow from below.


Refers to: src/Microsoft.ML.PCA/PcaTransformer.cs:107 in b54ce70. [](commit_id = b54ce70, deletion_comment = False)

@sfilipi
Copy link
Member

sfilipi commented Feb 1, 2019

    public sealed class ColumnInfo

one line XML


Refers to: src/Microsoft.ML.PCA/PcaTransformer.cs:99 in b54ce70. [](commit_id = b54ce70, deletion_comment = False)

@sfilipi
Copy link
Member

sfilipi commented Feb 1, 2019

    public sealed class ColumnInfo

move to estimator.


Refers to: src/Microsoft.ML.PCA/PcaTransformer.cs:99 in b54ce70. [](commit_id = b54ce70, deletion_comment = False)

@Ivanidzo4ka
Copy link
Contributor

Ivanidzo4ka commented Feb 1, 2019

I think @artidoro already done all this work in his PR #2366 maybe it's better to collaborate with him and close this PR?

@ganik ganik closed this Feb 1, 2019
@ganik
Copy link
Member Author

ganik commented Feb 1, 2019

right, will ask @artidoro to assign project13 issues onto himself to avoid confusion


In reply to: 459872486 [](ancestors = 459872486)

@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lockdown Microsoft.ML.PCA public surface
3 participants