-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Creation of components through MLContext and cleanup (GcnNorm, LpNorm, RandomFourier, CustomStopWords, VectorWhiten, PCA) #2366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2366 +/- ##
==========================================
- Coverage 71.26% 71.17% -0.09%
==========================================
Files 785 780 -5
Lines 140946 140404 -542
Branches 16108 16053 -55
==========================================
- Hits 100440 99936 -504
+ Misses 36039 36017 -22
+ Partials 4467 4451 -16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just a few comments about adding more information in the docs. If this isn't the appropriate PR for adding detailed docs info, can you make sure they are listed in #1209 as a to-do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is part of the work outlined in #1798, and focuses on the GcnNorm, LpNorm, RandomFourier, CustomStopWords, VectorWhiten, PCA transformers/estimators:
fixes #2275
If I wrote (not a ITransformer) on the #1798 issue, and this PR number appears on the same line, I renamed the Arguments to Options, and tried to make it internal.