Skip to content

Fix naming of Options argument in TensorFlowTransform API #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2019

Conversation

abgoswam
Copy link
Member

@abgoswam abgoswam commented Feb 3, 2019

Fixes #2391

  • Renamed Options argument of the TensorFlowTransform API to options

@abgoswam abgoswam changed the title rename args -> options Fix naming of Options argument in TensorFlowTransform API Feb 3, 2019
@artidoro
Copy link
Contributor

artidoro commented Feb 3, 2019

I think much of this work is already taken care of in #2367, let's double check and sync. #Resolved

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #2392 into master will increase coverage by <.01%.
The diff coverage is 72.13%.

@@            Coverage Diff             @@
##           master    #2392      +/-   ##
==========================================
+ Coverage   71.25%   71.25%   +<.01%     
==========================================
  Files         783      783              
  Lines      140781   140781              
  Branches    16088    16088              
==========================================
+ Hits       100311   100313       +2     
+ Misses      36016    36015       -1     
+ Partials     4454     4453       -1
Flag Coverage Δ
#Debug 71.25% <72.13%> (ø) ⬆️
#production 67.6% <72.13%> (ø) ⬆️
#test 85.3% <ø> (ø) ⬆️

Copy link
Contributor

@zeahmed zeahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. LGTM!

@abgoswam
Copy link
Member Author

abgoswam commented Feb 4, 2019

Let me check this in since I am using search criteria "Options args" for find+replace in my PRs (thats how i found this issue)

If you find other inconsistencies with TFTransform we can do those separately in your PR #2367.


In reply to: 460088646 [](ancestors = 460088646)

@abgoswam abgoswam merged commit 2dfc51a into dotnet:master Feb 4, 2019
@abgoswam abgoswam deleted the abgoswam/options_TFTransform branch February 20, 2019 16:58
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants