Skip to content

Nuget package updates #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2019
Merged

Nuget package updates #2690

merged 1 commit into from
Feb 23, 2019

Conversation

singlis
Copy link
Member

@singlis singlis commented Feb 22, 2019

  • Removed ResultProcessor and Maml from Microsoft.ML nuget. These are
    currently not in a nuget package
  • Moved Sweeper from Microsoft.ML to Microsoft.ML.Sweep.
  • Updated nuget references as there were some other non-related errors
    for ONNX Transformer.

This fixes #689

@singlis singlis self-assigned this Feb 22, 2019
@Ivanidzo4ka
Copy link
Contributor

<ProjectReference Include="..\Microsoft.ML.ResultProcessor\Microsoft.ML.ResultProcessor.csproj" />

You either need to include it to Microsoft.ML.Sweep nuget, or remove reference to it.
Otherwise I don't understand how it will bring that dll.


Refers to: src/Microsoft.ML.Sweeper/Microsoft.ML.Sweeper.csproj:15 in bc31bb5. [](commit_id = bc31bb5, deletion_comment = False)

@@ -3,12 +3,11 @@
<PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>CORECLR</DefineConstants>
<IncludeInPackage>Microsoft.ML</IncludeInPackage>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML [](start = 32, length = 2)

Microsoft.ML.Sweep? you need this dll for ResultProcessor.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not put these in Sweep. Maybe another nuget package for execution? Microsoft.ML.Exec? This would include both maml and results processor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we just don't ship Microsoft.ML.Sweeper in any NuGet package for now, until someone makes a case that it must be shipped?


In reply to: 259190210 [](ancestors = 259190210)

Copy link
Member Author

@singlis singlis Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW - if there is a high level name for a package that can include sweep, results processor and maml, Im open to that as well -- preferably its more directed and not something like "Microsoft.ML.Misc" as that I think leads to a catch-all situation.

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double that, I don't see any reason to ship Sweeper right now.
I've went through code, and I don't see any entrypoints, so it's not consumable by Nimbus, and everything else we don't care right now.
Sorry for assigning you confusing issue.


In reply to: 259440526 [](ancestors = 259440526,259190210)

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@44c3113). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2690   +/-   ##
=========================================
  Coverage          ?   71.59%           
=========================================
  Files             ?      805           
  Lines             ?   142004           
  Branches          ?    16119           
=========================================
  Hits              ?   101673           
  Misses            ?    35891           
  Partials          ?     4440
Flag Coverage Δ
#Debug 71.59% <ø> (?)
#production 67.89% <ø> (?)
#test 85.73% <ø> (?)

@@ -6,7 +6,7 @@
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\Microsoft.ML.OnnxTransform\Microsoft.ML.OnnxTransform.nupkgproj" />
<ProjectReference Include="..\Microsoft.ML.OnnxTransformer\Microsoft.ML.OnnxTransformer.nupkgproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is going on here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uggh, I think nuget just skips over project references it can't find.

Can we get this fix in a separate PR?


In reply to: 259437310 [](ancestors = 259437310)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - you get just a warning. Sure I can move this into a different PR.

@singlis
Copy link
Member Author

singlis commented Feb 23, 2019

OK, I removed ResultProcess, Maml and Sweeper from the Microsoft.ML package. I will also post a new PR that fixes the pathing for Onnx transform

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eerhardt eerhardt merged commit 160eade into dotnet:master Feb 23, 2019
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@singlis singlis deleted the singlis/nuget branch March 7, 2019 00:53
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing Sweeper, PipelineInference, and ResultProcessor assemblies from Microsoft.ML nuget
3 participants