Skip to content

Nuget package updates #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2019
Merged

Nuget package updates #2690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Microsoft.ML.Maml/Microsoft.ML.Maml.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,11 @@
<PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>CORECLR</DefineConstants>
<IncludeInPackage>Microsoft.ML</IncludeInPackage>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML [](start = 32, length = 2)

Microsoft.ML.Sweep? you need this dll for ResultProcessor.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not put these in Sweep. Maybe another nuget package for execution? Microsoft.ML.Exec? This would include both maml and results processor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we just don't ship Microsoft.ML.Sweeper in any NuGet package for now, until someone makes a case that it must be shipped?

In reply to: 259190210 [](ancestors = 259190210)

Copy link
Member Author

@singlis singlis Feb 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW - if there is a high level name for a package that can include sweep, results processor and maml, Im open to that as well -- preferably its more directed and not something like "Microsoft.ML.Misc" as that I think leads to a catch-all situation.

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka Feb 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double that, I don't see any reason to ship Sweeper right now.
I've went through code, and I don't see any entrypoints, so it's not consumable by Nimbus, and everything else we don't care right now.
Sorry for assigning you confusing issue.

In reply to: 259440526 [](ancestors = 259440526,259190210)

<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\Microsoft.ML.Core\Microsoft.ML.Core.csproj" />
</ItemGroup>

</Project>
</Project>
1 change: 0 additions & 1 deletion src/Microsoft.ML.ResultProcessor/Microsoft.ML.ResultProcessor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML</IncludeInPackage>
<DefineConstants>CORECLR</DefineConstants>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>
Expand Down
1 change: 0 additions & 1 deletion src/Microsoft.ML.Sweeper/Microsoft.ML.Sweeper.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML</IncludeInPackage>
<DefineConstants>CORECLR</DefineConstants>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>
Expand Down