updating namespaces #2914

sfilipi · 2019-03-11T21:29:18Z

Towards #2751

Microsoft.ML.LightGBM -> changes to Microsoft.ML.Trainers.LightGBM
Microsoft.ML.Transforms.FeatureSelection -> moves to Microsoft.ML.Transforms

eerhardt · 2019-03-11T21:55:49Z

src/Microsoft.ML.LightGBM/Parallel/IParallel.cs

@@ -8,7 +8,7 @@
 using Microsoft.ML.EntryPoints;
 using Microsoft.ML.Runtime;

-namespace Microsoft.ML.LightGBM
+namespace Microsoft.ML.Trainers.LightGBM


If we are changing all of these places, should we start using the new casing we decided on in #2762.

namespace Microsoft.ML.Trainers.LightGbm #Resolved

How about assembly names? #Resolved

It kind of feels like if that is our casing... we should probably case it the same way everywhere. #Resolved

sfilipi · 2019-03-12T07:08:18Z

I have renamed the package definition files in disc, but git didn't pick up the change. Will update and re-post. #Resolved

eerhardt · 2019-03-12T13:53:38Z

I have renamed the package definition files in disc, but git didn't pick up the change.

My suggestion would be to either use a case sensitive file system (like a Linux box), or use git mv -f on Windows. #Resolved

Microsoft.ML.Transforms.FeatureSelection -> moves to Microsoft.ML.Transforms

and the ImageLoader transform moved to Microsoft.ML.Data together with the TextLoader.

sfilipi · 2019-03-12T20:08:47Z

thanks Eric.

In reply to: 472009849 [](ancestors = 472009849)

eerhardt · 2019-03-12T20:54:13Z

src/Microsoft.ML.Console/Microsoft.ML.Console.csproj

@@ -13,10 +13,10 @@
    <ProjectReference Include="..\Microsoft.ML.Data\Microsoft.ML.Data.csproj" />
    <ProjectReference Include="..\Microsoft.ML.Ensemble\Microsoft.ML.Ensemble.csproj" />
    <ProjectReference Include="..\Microsoft.ML.FastTree\Microsoft.ML.FastTree.csproj" />
+    <ProjectReference Include="..\Microsoft.ML.LightGBM\Microsoft.ML.LightGbm.csproj" />


LightGBM => LightGbm #Resolved

eerhardt · 2019-03-12T20:54:57Z

[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.LightGBM.StaticPipe" + PublicKey.Value)]

LightGBM => LightGbm #Resolved

Refers to: src/Microsoft.ML.LightGBM/Properties/AssemblyInfo.cs:9 in 3d181b9. [](commit_id = 3d181b9, deletion_comment = False)

eerhardt · 2019-03-12T20:55:33Z

<IncludeInPackage>Microsoft.ML.LightGBM</IncludeInPackage>

LightGBM => LightGbm #Resolved

Refers to: src/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.csproj:5 in 3d181b9. [](commit_id = 3d181b9, deletion_comment = False)

eerhardt · 2019-03-12T20:56:30Z

src/Microsoft.ML.LightGBM.StaticPipe/Microsoft.ML.LightGBM.StaticPipe.csproj

@@ -6,7 +6,7 @@

  <ItemGroup>
    <ProjectReference Include="..\Microsoft.ML.Data\Microsoft.ML.Data.csproj" />
-    <ProjectReference Include="..\Microsoft.ML.LightGBM\Microsoft.ML.LightGBM.csproj" />
+    <ProjectReference Include="..\Microsoft.ML.LightGBM\Microsoft.ML.LightGbm.csproj" />


You changed the casing of the folder, right? \Microsoft.ML.LightGBM\ => \Microsoft.ML.LightGbm\ or else the Linux build is gonna fail. #Resolved

Ivanidzo4ka · 2019-03-12T21:51:21Z

    // This example requires installation of additional nuget package <a href="https://www.nuget.org/packages/Microsoft.ML.LightGBM/">Microsoft.ML.LightGBM</a>.

It should become LightGbm? #Resolved

Refers to: docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/LightGbmWithOptions.cs:8 in cfcc7d8. [](commit_id = cfcc7d8, deletion_comment = False)

Ivanidzo4ka

…linux build.

codecov · 2019-03-13T07:51:46Z

Codecov Report

Merging #2914 into master will increase coverage by <.01%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master    #2914      +/-   ##
==========================================
+ Coverage   72.19%   72.19%   +<.01%     
==========================================
  Files         796      796              
  Lines      142023   142023              
  Branches    16046    16046              
==========================================
+ Hits       102527   102531       +4     
+ Misses      35116    35113       -3     
+ Partials     4380     4379       -1

Flag	Coverage Δ
#Debug	`72.19% <96.96%> (ø)`	⬆️
#production	`67.98% <0%> (ø)`	⬆️
#test	`88.3% <100%> (ø)`	⬆️

Impacted Files	Coverage Δ
...rc/Microsoft.ML.LightGbm/Parallel/SingleTrainer.cs	`36.84% <ø> (ø)`
src/Microsoft.ML.LightGbm/LightGbmArguments.cs	`89.63% <ø> (ø)`
...est/Microsoft.ML.Predictor.Tests/TestPredictors.cs	`63.8% <ø> (ø)`	⬆️
....ML.Data/Scorers/FeatureContributionCalculation.cs	`94.24% <ø> (ø)`	⬆️
src/Microsoft.ML.ImageAnalytics/ImageLoader.cs	`84.55% <ø> (ø)`	⬆️
src/Microsoft.ML.ImageAnalytics/ImageResizer.cs	`84.64% <ø> (ø)`	⬆️
src/Microsoft.ML.LightGbm/LightGbmCatalog.cs	`100% <ø> (ø)`
...rc/Microsoft.ML.LightGbm/LightGbmRankingTrainer.cs	`73.46% <ø> (ø)`
...rc/Microsoft.ML.LightGbm/WrappedLightGbmDataset.cs	`76.33% <ø> (ø)`
...Microsoft.ML.Transforms/FeatureSelectionCatalog.cs	`100% <ø> (ø)`	⬆️
... and 36 more

eerhardt · 2019-03-13T14:14:42Z

src/Microsoft.ML.Data/Prediction/ICalculateFeatureContribution.cs

+    /// <summary>
+    /// Support for feature contribution calculation.
+    /// </summary>
+    public sealed class FeatureContributionCalculator


I'm not seeing how this class is used anywhere in the code.

Can it be deleted?

It appears the way this is working is that we have a public API that takes in a ICalculateFeatureContribution (the public interface above) object, and then we internally cast that same object to IFeatureContributionMapper (the internal interface above that). I don't see where we are using this public class anywhere in our code.

cc @TomFinley @rogancarr

tried to remove it, and just use the IFeatureContributionMapper, but it will need the GetFeatureContributionMapper, and the ValueMapper to be public too. The ValueMapper is internal atm.

In reply to: 265147046 [](ancestors = 265147046)

I was able to remove it, and make the solution build successfully:

eerhardt@cd1ac9f

(Obviously this is outside of the scope of this current PR - which is just moving namespaces. Maybe we should open an issue for this design, as I think it kind of "smells".)

oh ic, you've removed it completely. I was merging it with the IFeatureContributionMapper. I'll create an issue.

eerhardt · 2019-03-13T14:17:28Z

It doesn't look like this file has been renamed for the right casing - the file is still Microsoft.ML.LightGBM.csproj #Resolved

Refers to: src/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.csproj:1 in 47d01a7. [](commit_id = 47d01a7, deletion_comment = False)

sfilipi requested review from eerhardt, singlis, Ivanidzo4ka and TomFinley March 11, 2019 21:29

sfilipi self-assigned this Mar 11, 2019

sfilipi added this to the 0319 milestone Mar 11, 2019

eerhardt reviewed Mar 11, 2019

View reviewed changes

sfilipi added 3 commits March 12, 2019 12:39

Microsoft.ML.LightGBM -> changes to Microsoft.ML.Trainers.LightGBM

bf7fa28

Microsoft.ML.Transforms.FeatureSelection -> moves to Microsoft.ML.Transforms

ImageAnalytics -> Transforms.Images

629c39c

and the ImageLoader transform moved to Microsoft.ML.Data together with the TextLoader.

LightGBM -> LightGbm for namespace, assembly and package.

00ac2ef

renaming the LightGBM project, and packages.

3d181b9

sfilipi force-pushed the namespace2751 branch from 0ef338b to 3d181b9 Compare March 12, 2019 20:45

eerhardt reviewed Mar 12, 2019

View reviewed changes

sfilipi added 2 commits March 12, 2019 14:10

moving the few public types outside of ML.Model

739913b

updating the casing on LightGbm project and assembly references

cfcc7d8

Ivanidzo4ka approved these changes Mar 12, 2019

View reviewed changes

Regenerate the catalog, and rename the csproj in LightGBM to fix the …

a11f63a

…linux build.

sfilipi force-pushed the namespace2751 branch from a11f63a to 47d01a7 Compare March 13, 2019 07:15

eerhardt reviewed Mar 13, 2019

View reviewed changes

fixing the casing on the package urls and the csproj file.

28debb3

sfilipi force-pushed the namespace2751 branch from 47d01a7 to 28debb3 Compare March 13, 2019 16:22

sfilipi added 3 commits March 13, 2019 10:25

merging from master

14a7d5b

regenerating the catalog

8a05426

nit

30d1e73

eerhardt approved these changes Mar 13, 2019

View reviewed changes

sfilipi merged commit c5aab77 into dotnet:master Mar 13, 2019

sfilipi deleted the namespace2751 branch March 13, 2019 18:37

ghost locked as resolved and limited conversation to collaborators Mar 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updating namespaces #2914

updating namespaces #2914

sfilipi commented Mar 11, 2019

eerhardt Mar 11, 2019 •

edited by sfilipi

Loading

sfilipi Mar 11, 2019 •

edited

Loading

eerhardt Mar 12, 2019 •

edited by sfilipi

Loading

sfilipi commented Mar 12, 2019 •

edited

Loading

eerhardt commented Mar 12, 2019 •

edited by sfilipi

Loading

sfilipi commented Mar 12, 2019

eerhardt Mar 12, 2019 •

edited by sfilipi

Loading

eerhardt commented Mar 12, 2019 •

edited by sfilipi

Loading

eerhardt commented Mar 12, 2019 •

edited by sfilipi

Loading

eerhardt Mar 12, 2019 •

edited by sfilipi

Loading

Ivanidzo4ka commented Mar 12, 2019 •

edited by sfilipi

Loading

Ivanidzo4ka left a comment

codecov bot commented Mar 13, 2019 •

edited

Loading

eerhardt Mar 13, 2019

sfilipi Mar 13, 2019

eerhardt Mar 13, 2019 •

edited

Loading

sfilipi Mar 13, 2019

eerhardt commented Mar 13, 2019 •

edited by sfilipi

Loading

updating namespaces #2914

updating namespaces #2914

Conversation

sfilipi commented Mar 11, 2019

eerhardt Mar 11, 2019 • edited by sfilipi Loading

Choose a reason for hiding this comment

sfilipi Mar 11, 2019 • edited Loading

Choose a reason for hiding this comment

eerhardt Mar 12, 2019 • edited by sfilipi Loading

Choose a reason for hiding this comment

sfilipi commented Mar 12, 2019 • edited Loading

eerhardt commented Mar 12, 2019 • edited by sfilipi Loading

sfilipi commented Mar 12, 2019

eerhardt Mar 12, 2019 • edited by sfilipi Loading

Choose a reason for hiding this comment

eerhardt commented Mar 12, 2019 • edited by sfilipi Loading

eerhardt commented Mar 12, 2019 • edited by sfilipi Loading

eerhardt Mar 12, 2019 • edited by sfilipi Loading

Choose a reason for hiding this comment

Ivanidzo4ka commented Mar 12, 2019 • edited by sfilipi Loading

Ivanidzo4ka left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 13, 2019 • edited Loading

Codecov Report

eerhardt Mar 13, 2019

Choose a reason for hiding this comment

sfilipi Mar 13, 2019

Choose a reason for hiding this comment

eerhardt Mar 13, 2019 • edited Loading

Choose a reason for hiding this comment

sfilipi Mar 13, 2019

Choose a reason for hiding this comment

eerhardt commented Mar 13, 2019 • edited by sfilipi Loading

eerhardt Mar 11, 2019 •

edited by sfilipi

Loading

sfilipi Mar 11, 2019 •

edited

Loading

eerhardt Mar 12, 2019 •

edited by sfilipi

Loading

sfilipi commented Mar 12, 2019 •

edited

Loading

eerhardt commented Mar 12, 2019 •

edited by sfilipi

Loading

eerhardt Mar 12, 2019 •

edited by sfilipi

Loading

eerhardt commented Mar 12, 2019 •

edited by sfilipi

Loading

eerhardt commented Mar 12, 2019 •

edited by sfilipi

Loading

eerhardt Mar 12, 2019 •

edited by sfilipi

Loading

Ivanidzo4ka commented Mar 12, 2019 •

edited by sfilipi

Loading

codecov bot commented Mar 13, 2019 •

edited

Loading

eerhardt Mar 13, 2019 •

edited

Loading

eerhardt commented Mar 13, 2019 •

edited by sfilipi

Loading