MLContext.Model.Load overloads that take file path instead of stream. #3008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3008 +/- ##
==========================================
- Coverage 72.35% 72.35% -0.01%
==========================================
Files 803 803
Lines 143295 143278 -17
Branches 16155 16155
==========================================
- Hits 103678 103664 -14
+ Misses 35191 35189 -2
+ Partials 4426 4425 -1
|
eerhardt
reviewed
Mar 19, 2019
codemzs
force-pushed
the
modeloadfilepath1
branch
from
acbf668 to
b2a958c
Compare
eerhardt
reviewed
Mar 19, 2019
| /// </summary> | ||
| /// <param name="stream">A readable, seekable stream to load from.</param> | ||
| /// <returns>A model of type <see cref="CompositeDataLoader{IMultiStreamSource, ITransformer}"/> containing the loader | ||
| /// and the transformer chain.</returns> | ||
| public IDataLoader<IMultiStreamSource> Load(Stream stream) | ||
| public IDataLoader<IMultiStreamSource> LoadDataLoader(Stream stream) |
There was a problem hiding this comment.
Should we make a similar change for the Save method?
/// <summary>
/// Save the model to the file.
/// </summary>
/// <param name="model">The trained model to be saved.</param>
/// <param name="filePath">Path where model should be saved.</param>
public void Save<TSource>(IDataLoader<TSource> model, string filePath)
{
using (var stream = File.Create(filePath))
Save(model, stream);
}These are no longer symmetric.
There was a problem hiding this comment.
Yes but this is Load API PR. I have created another PR to rename this for Save API #3019
There was a problem hiding this comment.
@eerhardt @TomFinley feels we shouldn't change for Save because in .Net we have ReadChar, ReadInt, ReadDouble, etc but Write() is just one loaded set of methods. Thoughts?
There was a problem hiding this comment.
I dont quite follow is there more discussion on github?
In reply to: 267100385 [](ancestors = 267100385)
singlis
reviewed
Mar 20, 2019
| /// </summary> | ||
| /// <param name="modelPath">Path to model.</param> | ||
| /// <param name="inputSchema">Will contain the input schema for the model. If the model was saved using older APIs | ||
| /// it may not contain an input schema, in this case <paramref name="inputSchema"/> will be null.</param> |
There was a problem hiding this comment.
Is it worth calling out the behavior for older models having a null input schema? That should never be the case now right?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2991