Rename Save API for DataLoader to SaveDataLoader.

[codemzs]

towards #2991

[TomFinley]

I don't necessarily agree with this change. As far as I can tell, this PR was the result of an off hand comment by @eerhardt here.

I think it is confusing to have methods that have different results and return values and whatnot to be overloads, that is, have the same name, which is why I agreed with the other point here. But I think overlods that accept different types as parameters are fine and well established. (Indeed that's why overloads exist in the first place.)

Consider for an analogous situation, BinaryReader. Note all the Read* methods -- all differently named, all different return values. Now consider BinaryWriter. Basically one Write with different arguments. So the idea that there has to be a "master symmetry" . This loading and saving strikes me as rather similar.

It wouldn't be an absolute disaster if this PR was checked in of course, but I consider the original premise that led to this PR to be questionable. Also of course there is no actual issue where this is proposed, discussed, or anything else like this. Just an off handed question, not even really phrased even as a suggestion, about whether we should do this, where we didn't even as far as I tell think seriously about whether the answer to that question might be "no." (Clearly .NET SDK doesn't think so, as we see above!)

[TomFinley]

Incidentally I am removing this from public surface in #3044. Maybe we close this @codemzs, and if you would be so kind as to review that one?

[TomFinley]

I think this change is now obviated by #3044, since after discussions with @eerhardt and @yaeldekel as captured in #3025, we decided perhaps the more radical step of removing this entirely (as its presence is confusing, no matter what we name it)

[TomFinley]

I think this change is now obviated by #3044, since after discussions with @eerhardt and @yaeldekel as captured in #3025, we decided perhaps the more radical step of removing this entirely (as its presence is confusing, no matter what we name it)

So, what I mean is, should we close this @codemzs ?